[jira] [Commented] (LUCENE-5645) StringHelper should check for empty string of "tests.seed" system property

["David Smiley (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13990224#comment-13990224 ] 

David Smiley commented on LUCENE-5645:
--------------------------------------

The change is obviously trivial; I won't provide a patch.  Change line 158 from:
{code:java}
if (prop != null) {
{code}
to
{code:java}
if (prop != null && prop.length() > 0) {
{code}

I'll commit it in 24 hours or upon the first +1 I see.

> StringHelper should check for empty string of "tests.seed" system property
> --------------------------------------------------------------------------
>
>                 Key: LUCENE-5645
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5645
>             Project: Lucene - Core
>          Issue Type: Bug
>    Affects Versions: 4.8, 5.0
>            Reporter: David Smiley
>            Assignee: David Smiley
>            Priority: Minor
>             Fix For: 4.8.1, 5.0
>
>
> As of LUCENE-5604 (committed to v4.8), StringHelper will initialize GOOD_FAST_HASH_SEED based on the system property "tests.seed" if it is set.  Unfortunately it doesn't do an empty-string check, and it's common at least in my setup that copies Lucene's maven pom.xml that the string will be empty unless I set it on the command line.  FWIW Randomized Testing does do an empty-string check.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org