[GitHub] [incubator-celeborn] pan3793 commented on a diff in pull request #1437: [CELEBORN-533] fix bug that in k8s, SIGTERM can't be catched by worke…

["pan3793 (via GitHub)" <gi...@apache.org>]

pan3793 commented on code in PR #1437:
URL: https://github.com/apache/incubator-celeborn/pull/1437#discussion_r1169904317


##########
charts/celeborn/templates/worker-statefulset.yaml:
##########
@@ -81,7 +81,7 @@ spec:
           - "/bin/sh"
           - '-c'
           {{- $namespace := .Release.Namespace }}
-          - "until {{ range until (.Values.masterReplicas |int) }}nslookup celeborn-master-{{ . }}.celeborn-master-svc.{{ $namespace }}.svc.{{ $.Values.cluster.name }}.local && {{ end }}true; do echo waiting for master; sleep 2; done && /opt/celeborn/sbin/start-worker.sh"
+          - "until {{ range until (.Values.masterReplicas |int) }}nslookup celeborn-master-{{ . }}.celeborn-master-svc.{{ $namespace }}.svc.{{ $.Values.cluster.name }}.local && {{ end }}true; do echo waiting for master; sleep 2; done && exec /opt/celeborn/sbin/start-worker.sh"

Review Comment:
   it should work w/o this change



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org