[jira] Commented: (SLING-942) Have JSONArray.getJSONObject(int) construct JSONObject if value is String

["Carl Hall (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12702508#action_12702508 ] 

Carl Hall commented on SLING-942:
---------------------------------

Looks good to me.  Thanks for extending the patch to getJSONArray and the opt* methods.

> Have JSONArray.getJSONObject(int) construct JSONObject if value is String
> -------------------------------------------------------------------------
>
>                 Key: SLING-942
>                 URL: https://issues.apache.org/jira/browse/SLING-942
>             Project: Sling
>          Issue Type: Improvement
>          Components: Commons JSON
>    Affects Versions: Commons JSON 2.0.2, Commons JSON 2.0.4
>            Reporter: Carl Hall
>            Assignee: Felix Meschberger
>         Attachments: SLING-942-fmeschbe.patch, sling-942.diff
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> JSONArray.getJSONObject(int) current checks for JSONObject and throws an exception if instanceof fails.  I discovered this after excepting to get back a JSONObject from this but debugging showed that the value was a JSON String.  This functionality could be enhanced by checking for String and converting to a JSONObject if possible.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.