You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Paul Elschot (JIRA)" <ji...@apache.org> on 2009/01/05 19:29:44 UTC

[jira] Commented: (LUCENE-1504) SerialChainFilter should use DocSet API rather then deprecated BitSet API

    [ https://issues.apache.org/jira/browse/LUCENE-1504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12660839#action_12660839 ] 

Paul Elschot commented on LUCENE-1504:
--------------------------------------

In trunk, there is no more need to call Filter.bits().

But the same functions are also  present in contrib/queries/.../BooleanFilter.java and in contrib/misc*/.../ChainedFilter.java, and these were already adapted to use Filter.getDocIdSet().
These also use o.a.l.util.OpenBitSet which is normally slightly faster than java's BitSet.

In case you prefer to use one of these, a dependency on the corresponding contrib module may have to be added in the build process of the spatial contrib.



> SerialChainFilter should use DocSet API rather then deprecated BitSet API
> -------------------------------------------------------------------------
>
>                 Key: LUCENE-1504
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1504
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/spatial
>            Reporter: Ryan McKinley
>             Fix For: 2.9
>
>         Attachments: LUCENE-1504.patch
>
>
> From erik's comments in LUCENE-1387
>     * Maybe the Filter's should be using the DocIdSet API rather than the BitSet deprecated stuff? We can refactor that after being committed I supposed, but not something we want to leave like that.
> We should also look at moving SerialChainFilter out of the spatial contrib since it is more generally useful then just spatial search.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: java-dev-help@lucene.apache.org