You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "zll600 (via GitHub)" <gi...@apache.org> on 2024/02/23 06:33:02 UTC
[PR] fix: install gawk explicitly [apisix]
zll600 opened a new pull request, #10959:
URL: https://github.com/apache/apisix/pull/10959
### Description
<!-- Please include a summary of the change and which issue is fixed. -->
<!-- Please also include relevant motivation and context. -->
Fixes # (issue)
### Checklist
- [ ] I have explained the need for this PR and the problem it solves
- [ ] I have explained the changes or the new features added to this PR
- [ ] I have added tests corresponding to this change
- [ ] I have updated the documentation to reflect this change
- [ ] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
<!--
Note
1. Mark the PR as draft until it's ready to be reviewed.
2. Always add/update tests for any changes unless you have a good reason.
3. Always update the documentation to reflect the changes made in the PR.
4. Make a new commit to resolve conversations instead of `push -f`.
5. To resolve merge conflicts, merge master instead of rebasing.
6. Use "request review" to notify the reviewer after making changes.
7. Only a reviewer can mark a conversation as resolved.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: add apisix/plugin/limit-req to Makfile [apisix]
Posted by "zll600 (via GitHub)" <gi...@apache.org>.
zll600 commented on code in PR #10959:
URL: https://github.com/apache/apisix/pull/10959#discussion_r1500376441
##########
ci/common.sh:
##########
@@ -170,7 +170,7 @@ GRPC_SERVER_EXAMPLE_VER=20210819
linux_get_dependencies () {
apt update
- apt install -y cpanminus build-essential libncurses5-dev libreadline-dev libssl-dev perl libpcre3 libpcre3-dev libldap2-dev
+ apt install -y cpanminus build-essential libncurses5-dev libreadline-dev libssl-dev perl libpcre3 libpcre3-dev libldap2-dev gawk
Review Comment:
when I test this pr locally, this is needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: add apisix/plugin/limit-req to makefile [apisix]
Posted by "shreemaan-abhishek (via GitHub)" <gi...@apache.org>.
shreemaan-abhishek merged PR #10959:
URL: https://github.com/apache/apisix/pull/10959
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: add apisix/plugin/limit-req to Makfile [apisix]
Posted by "shreemaan-abhishek (via GitHub)" <gi...@apache.org>.
shreemaan-abhishek commented on code in PR #10959:
URL: https://github.com/apache/apisix/pull/10959#discussion_r1500375279
##########
ci/common.sh:
##########
@@ -170,7 +170,7 @@ GRPC_SERVER_EXAMPLE_VER=20210819
linux_get_dependencies () {
apt update
- apt install -y cpanminus build-essential libncurses5-dev libreadline-dev libssl-dev perl libpcre3 libpcre3-dev libldap2-dev
+ apt install -y cpanminus build-essential libncurses5-dev libreadline-dev libssl-dev perl libpcre3 libpcre3-dev libldap2-dev gawk
Review Comment:
is this needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: add apisix/plugin/limit-req to Makfile [apisix]
Posted by "zll600 (via GitHub)" <gi...@apache.org>.
zll600 commented on code in PR #10959:
URL: https://github.com/apache/apisix/pull/10959#discussion_r1500376441
##########
ci/common.sh:
##########
@@ -170,7 +170,7 @@ GRPC_SERVER_EXAMPLE_VER=20210819
linux_get_dependencies () {
apt update
- apt install -y cpanminus build-essential libncurses5-dev libreadline-dev libssl-dev perl libpcre3 libpcre3-dev libldap2-dev
+ apt install -y cpanminus build-essential libncurses5-dev libreadline-dev libssl-dev perl libpcre3 libpcre3-dev libldap2-dev gawk
Review Comment:
when I test this pr locally, this is needed. otherwise some error will occur.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: add apisix/plugin/limit-req to Makfile [apisix]
Posted by "zll600 (via GitHub)" <gi...@apache.org>.
zll600 commented on code in PR #10959:
URL: https://github.com/apache/apisix/pull/10959#discussion_r1500544344
##########
ci/common.sh:
##########
@@ -170,7 +170,7 @@ GRPC_SERVER_EXAMPLE_VER=20210819
linux_get_dependencies () {
apt update
- apt install -y cpanminus build-essential libncurses5-dev libreadline-dev libssl-dev perl libpcre3 libpcre3-dev libldap2-dev
+ apt install -y cpanminus build-essential libncurses5-dev libreadline-dev libssl-dev perl libpcre3 libpcre3-dev libldap2-dev gawk
Review Comment:
I do this according to the Makefile
https://github.com/apache/apisix/blob/869d095153df75fbe6e3edcf631340965fdd04ab/Makefile#L117-L123
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: add apisix/plugin/limit-req to makefile [apisix]
Posted by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org>.
monkeyDluffy6017 commented on code in PR #10959:
URL: https://github.com/apache/apisix/pull/10959#discussion_r1502097052
##########
ci/common.sh:
##########
@@ -170,7 +170,7 @@ GRPC_SERVER_EXAMPLE_VER=20210819
linux_get_dependencies () {
apt update
- apt install -y cpanminus build-essential libncurses5-dev libreadline-dev libssl-dev perl libpcre3 libpcre3-dev libldap2-dev
+ apt install -y cpanminus build-essential libncurses5-dev libreadline-dev libssl-dev perl libpcre3 libpcre3-dev libldap2-dev gawk
Review Comment:
please revert this change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: add apisix/plugin/limit-req to Makfile [apisix]
Posted by "zll600 (via GitHub)" <gi...@apache.org>.
zll600 commented on code in PR #10959:
URL: https://github.com/apache/apisix/pull/10959#discussion_r1500544344
##########
ci/common.sh:
##########
@@ -170,7 +170,7 @@ GRPC_SERVER_EXAMPLE_VER=20210819
linux_get_dependencies () {
apt update
- apt install -y cpanminus build-essential libncurses5-dev libreadline-dev libssl-dev perl libpcre3 libpcre3-dev libldap2-dev
+ apt install -y cpanminus build-essential libncurses5-dev libreadline-dev libssl-dev perl libpcre3 libpcre3-dev libldap2-dev gawk
Review Comment:
I do this according to the Makefile.
https://github.com/apache/apisix/blob/869d095153df75fbe6e3edcf631340965fdd04ab/Makefile#L117-L123
But `make help` has no side effects. So I can also revert this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: add apisix/plugin/limit-req to makefile [apisix]
Posted by "zll600 (via GitHub)" <gi...@apache.org>.
zll600 commented on PR #10959:
URL: https://github.com/apache/apisix/pull/10959#issuecomment-1963413518
@monkeyDluffy6017 @shreemaan-abhishek PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: add apisix/plugin/limit-req to Makfile [apisix]
Posted by "zll600 (via GitHub)" <gi...@apache.org>.
zll600 commented on code in PR #10959:
URL: https://github.com/apache/apisix/pull/10959#discussion_r1500376441
##########
ci/common.sh:
##########
@@ -170,7 +170,7 @@ GRPC_SERVER_EXAMPLE_VER=20210819
linux_get_dependencies () {
apt update
- apt install -y cpanminus build-essential libncurses5-dev libreadline-dev libssl-dev perl libpcre3 libpcre3-dev libldap2-dev
+ apt install -y cpanminus build-essential libncurses5-dev libreadline-dev libssl-dev perl libpcre3 libpcre3-dev libldap2-dev gawk
Review Comment:
when I test this pr locally, this is needed. otherwise some errors will occur.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: add apisix/plugin/limit-req to Makfile [apisix]
Posted by "shreemaan-abhishek (via GitHub)" <gi...@apache.org>.
shreemaan-abhishek commented on code in PR #10959:
URL: https://github.com/apache/apisix/pull/10959#discussion_r1500423170
##########
ci/common.sh:
##########
@@ -170,7 +170,7 @@ GRPC_SERVER_EXAMPLE_VER=20210819
linux_get_dependencies () {
apt update
- apt install -y cpanminus build-essential libncurses5-dev libreadline-dev libssl-dev perl libpcre3 libpcre3-dev libldap2-dev
+ apt install -y cpanminus build-essential libncurses5-dev libreadline-dev libssl-dev perl libpcre3 libpcre3-dev libldap2-dev gawk
Review Comment:
that doesn't explain this change 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: add apisix/plugin/limit-req to Makfile [apisix]
Posted by "zll600 (via GitHub)" <gi...@apache.org>.
zll600 commented on code in PR #10959:
URL: https://github.com/apache/apisix/pull/10959#discussion_r1500544344
##########
ci/common.sh:
##########
@@ -170,7 +170,7 @@ GRPC_SERVER_EXAMPLE_VER=20210819
linux_get_dependencies () {
apt update
- apt install -y cpanminus build-essential libncurses5-dev libreadline-dev libssl-dev perl libpcre3 libpcre3-dev libldap2-dev
+ apt install -y cpanminus build-essential libncurses5-dev libreadline-dev libssl-dev perl libpcre3 libpcre3-dev libldap2-dev gawk
Review Comment:
I do this according to the Makefile.
https://github.com/apache/apisix/blob/869d095153df75fbe6e3edcf631340965fdd04ab/Makefile#L117-L123
But `make help` has no side effects. So if you insist, I can revert this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org