You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ranger.apache.org by co...@apache.org on 2017/03/13 09:48:25 UTC
[2/3] ranger git commit: RANGEr-1388 - Improve error messages in
AtlasKafkaResourceMapper
RANGEr-1388 - Improve error messages in AtlasKafkaResourceMapper
Signed-off-by: Colm O hEigeartaigh <co...@apache.org>
Project: http://git-wip-us.apache.org/repos/asf/ranger/repo
Commit: http://git-wip-us.apache.org/repos/asf/ranger/commit/a4f1be82
Tree: http://git-wip-us.apache.org/repos/asf/ranger/tree/a4f1be82
Diff: http://git-wip-us.apache.org/repos/asf/ranger/diff/a4f1be82
Branch: refs/heads/master
Commit: a4f1be829c2eb1eb5bdaaa721ad30ffee7fe6530
Parents: 58018b2
Author: Colm O hEigeartaigh <co...@apache.org>
Authored: Thu Feb 16 15:41:08 2017 +0000
Committer: Colm O hEigeartaigh <co...@apache.org>
Committed: Mon Mar 13 09:40:33 2017 +0000
----------------------------------------------------------------------
.../ranger/tagsync/source/atlas/AtlasKafkaResourceMapper.java | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/ranger/blob/a4f1be82/tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasKafkaResourceMapper.java
----------------------------------------------------------------------
diff --git a/tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasKafkaResourceMapper.java b/tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasKafkaResourceMapper.java
index 9f1fc2d..09ae5d1 100644
--- a/tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasKafkaResourceMapper.java
+++ b/tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasKafkaResourceMapper.java
@@ -44,6 +44,10 @@ public class AtlasKafkaResourceMapper extends AtlasResourceMapper {
public RangerServiceResource buildResource(final IReferenceableInstance entity) throws Exception {
String qualifiedName = getEntityAttribute(entity, ENTITY_ATTRIBUTE_QUALIFIED_NAME, String.class);
+ if(StringUtils.isEmpty(qualifiedName)) {
+ throwExceptionWithMessage("attribute '" + ENTITY_ATTRIBUTE_QUALIFIED_NAME + "' not found in entity");
+ }
+
String topic = getResourceNameFromQualifiedName(qualifiedName);
if(StringUtils.isEmpty(topic)) {
@@ -57,10 +61,9 @@ public class AtlasKafkaResourceMapper extends AtlasResourceMapper {
}
if(StringUtils.isEmpty(clusterName)) {
- throwExceptionWithMessage("attribute '" + ENTITY_ATTRIBUTE_QUALIFIED_NAME + "' not found in entity");
+ throwExceptionWithMessage("Cluster name not found in attribute '" + ENTITY_ATTRIBUTE_QUALIFIED_NAME + "'");
}
-
Map<String, RangerPolicyResource> elements = new HashMap<String, RangerPolicy.RangerPolicyResource>();
Boolean isExcludes = Boolean.FALSE;
Boolean isRecursive = Boolean.TRUE;