[jira] [Updated] (LUCENE-8070) GeoExactCircle should not create circles that they do not fit in spheroid

["Ignacio Vera (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/LUCENE-8070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ignacio Vera updated LUCENE-8070:
---------------------------------
    Attachment: LUCENE-8070.patch
                LUCENE-8070-test.patch

Attached is a test showing the issue and a possible solution.

The solution (I propose) tries to prevent such circles to be constructed. The (maybe naive) assumption is that we should not allow circles that contain antipodal points. I was hoping to find a way to know the shorter distance the antipodal points on a planet but it seems harder than I expected. It seems to work to choose the smaller distance between the poles of the planet (at least for WGS84-like planets). What do you think?

P.S: I have changed the message of a thrown error as it should not be true any more. 

> GeoExactCircle should not create circles that they do not fit in spheroid 
> --------------------------------------------------------------------------
>
>                 Key: LUCENE-8070
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8070
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Ignacio Vera
>         Attachments: LUCENE-8070-test.patch, LUCENE-8070.patch
>
>
> Hi [~daddywri],
> I have seen test fail when we try to create circles that the don' t fit in the planet. I think sectors of the circle start overlapping to each other and the shape becomes invalid. The shape should prevent that to happen.
> I will attach a test and a proposed solution.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org