You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Niklas Nielsen <ni...@qni.dk> on 2014/01/10 00:45:17 UTC
Review Request 16769: Merged freeMemory() into memory().
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16769/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
Repository: mesos-git
Description
-------
Instead of having separate functions to get total and free system memory, this patch merge the two in memory().
memory() now returns a struct containing both stats.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 2c4ddb0
Diff: https://reviews.apache.org/r/16769/diff/
Testing
-------
make check and functional testing.
Thanks,
Niklas Nielsen
Re: Review Request 16769: Merged freeMemory() into memory().
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16769/#review31643
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On Jan. 13, 2014, 7:15 p.m., Niklas Nielsen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16769/
> -----------------------------------------------------------
>
> (Updated Jan. 13, 2014, 7:15 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Instead of having separate functions to get total and free system memory, this patch merge the two in memory().
> memory() now returns a struct containing both stats.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 2c4ddb0
>
> Diff: https://reviews.apache.org/r/16769/diff/
>
>
> Testing
> -------
>
> make check and functional testing.
>
>
> Thanks,
>
> Niklas Nielsen
>
>
Re: Review Request 16769: Merged freeMemory() into memory().
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16769/
-----------------------------------------------------------
(Updated Jan. 13, 2014, 11:15 a.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
Changes
-------
Addressed BenH's comments.
Repository: mesos-git
Description
-------
Instead of having separate functions to get total and free system memory, this patch merge the two in memory().
memory() now returns a struct containing both stats.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 2c4ddb0
Diff: https://reviews.apache.org/r/16769/diff/
Testing
-------
make check and functional testing.
Thanks,
Niklas Nielsen
Re: Review Request 16769: Merged freeMemory() into memory().
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16769/#review31489
-----------------------------------------------------------
Ship it!
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp
<https://reviews.apache.org/r/16769/#comment59995>
Please move '{' to newline. ;)
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp
<https://reviews.apache.org/r/16769/#comment59996>
s/mem/memory/ (overloading the function name is okay).
- Benjamin Hindman
On Jan. 9, 2014, 11:45 p.m., Niklas Nielsen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16769/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2014, 11:45 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Instead of having separate functions to get total and free system memory, this patch merge the two in memory().
> memory() now returns a struct containing both stats.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 2c4ddb0
>
> Diff: https://reviews.apache.org/r/16769/diff/
>
>
> Testing
> -------
>
> make check and functional testing.
>
>
> Thanks,
>
> Niklas Nielsen
>
>