You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "zwoop (via GitHub)" <gi...@apache.org> on 2023/02/12 17:39:34 UTC
[GitHub] [trafficserver] zwoop opened a new pull request, #9401: Removes the UglyStub file
zwoop opened a new pull request, #9401:
URL: https://github.com/apache/trafficserver/pull/9401
With all the cleanup, and refactoring etc., there are only a small number of things that needs the ugly stubs. Fixing those allowed us to eliminate the UglyLogStubs library completely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] cmcfarlen commented on pull request #9401: Removes the UglyStub file
Posted by "cmcfarlen (via GitHub)" <gi...@apache.org>.
cmcfarlen commented on PR #9401:
URL: https://github.com/apache/trafficserver/pull/9401#issuecomment-1430265129
We could move `new_UDPPacket` and `UDPPacketInternal::free` into `UnixUDPNet.cc` and then remove the extern from the `P_UDPPacket.h` file. The other `new_` functions could just call `new_UDPPacket` instead of the allocator directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop merged pull request #9401: Removes the UglyStub file
Posted by "zwoop (via GitHub)" <gi...@apache.org>.
zwoop merged PR #9401:
URL: https://github.com/apache/trafficserver/pull/9401
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #9401: Removes the UglyStub file
Posted by "zwoop (via GitHub)" <gi...@apache.org>.
zwoop commented on PR #9401:
URL: https://github.com/apache/trafficserver/pull/9401#issuecomment-1428247962
Changing this to a draft, while I iterate over fixing all the oddities.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] cmcfarlen commented on pull request #9401: Removes the UglyStub file
Posted by "cmcfarlen (via GitHub)" <gi...@apache.org>.
cmcfarlen commented on PR #9401:
URL: https://github.com/apache/trafficserver/pull/9401#issuecomment-1430266353
I really support this work as it's currently very complicated to add unit tests to much of the code. Any little bit helps.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #9401: Removes the UglyStub file
Posted by "zwoop (via GitHub)" <gi...@apache.org>.
zwoop commented on PR #9401:
URL: https://github.com/apache/trafficserver/pull/9401#issuecomment-1428919240
I think with this landed, we may be able to disconnect the dependencies on the ```udpPacketAllocator```, but doing so requires us to move some "inline" functions into proper classes (as static). Can't quite get it to work though, but landing this will at least put us in a better position to clean up this mess with the UDP dependencies.
I also think that resolving this may help fixing "make check" problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #9401: Removes the UglyStub file
Posted by "zwoop (via GitHub)" <gi...@apache.org>.
zwoop commented on PR #9401:
URL: https://github.com/apache/trafficserver/pull/9401#issuecomment-1427092171
Well, seems linux builds are different than OSX builds for UDP. Looking into the issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #9401: Removes the UglyStub file
Posted by "zwoop (via GitHub)" <gi...@apache.org>.
zwoop commented on PR #9401:
URL: https://github.com/apache/trafficserver/pull/9401#issuecomment-1430338163
> We could move `new_UDPPacket` and `UDPPacketInternal::free` into `UnixUDPNet.cc` and then remove the extern from the `P_UDPPacket.h` file. The other `new_` functions could just call `new_UDPPacket` instead of the allocator directly.
Yeh, I was trying that last night, and yes, I think this is right path, but ran into other problems. I think we should land this first, and then continue from there. I also think fixing all this will likely fix the "make check" issues on macOS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org