You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Josh Elser (JIRA)" <ji...@apache.org> on 2015/04/25 02:38:39 UTC

[jira] [Reopened] (HBASE-13078) IntegrationTestSendTraceRequests is a noop

     [ https://issues.apache.org/jira/browse/HBASE-13078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Josh Elser reopened HBASE-13078:
--------------------------------

Heyyyy [~stack]. Looks like you put the removal patch everywhere instead of just 0.98. Didn't we want to keep the test in place for >=1.* and apply HBASE-13078-v1.patch which adds in assertions?

> IntegrationTestSendTraceRequests is a noop
> ------------------------------------------
>
>                 Key: HBASE-13078
>                 URL: https://issues.apache.org/jira/browse/HBASE-13078
>             Project: HBase
>          Issue Type: Test
>          Components: integration tests
>            Reporter: Nick Dimiduk
>            Assignee: Josh Elser
>            Priority: Critical
>             Fix For: 2.0.0, 1.1.0, 1.0.2
>
>         Attachments: HBASE-13078-0.98-removal.patch, HBASE-13078-0.98-v1.patch, HBASE-13078-v1.patch, HBASE-13078.patch
>
>
> While pair-debugging with [~jeffreyz] on HBASE-13077, we noticed that IntegrationTestSendTraceRequests doesn't actually assert anything. This test should be converted to use a mini cluster, setup a POJOSpanReceiver, and then verify the spans collected.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)