You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "Xuanwo (via GitHub)" <gi...@apache.org> on 2023/05/08 08:19:33 UTC

[GitHub] [incubator-opendal] Xuanwo opened a new pull request, #2234: fix(services/s3): Return error if region not set for AWS S3

Xuanwo opened a new pull request, #2234:
URL: https://github.com/apache/incubator-opendal/pull/2234

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-opendal] Xuanwo merged pull request #2234: fix(services/s3): Return error if region not set for AWS S3

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo merged PR #2234:
URL: https://github.com/apache/incubator-opendal/pull/2234


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-opendal] saiintbrisson commented on pull request #2234: fix(services/s3): Return error if region not set for AWS S3

Posted by "saiintbrisson (via GitHub)" <gi...@apache.org>.
saiintbrisson commented on PR #2234:
URL: https://github.com/apache/incubator-opendal/pull/2234#issuecomment-1540465754

   Hi! This changed missed the doc here: https://github.com/apache/incubator-opendal/blob/21ebe0fc4f23f0a4a2eb01418e4e728599c090ae/core/src/services/s3/backend.rs#L373
   
   I'll come up with a PR fixing it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-opendal] Xuanwo commented on pull request #2234: fix(services/s3): Return error if region not set for AWS S3

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #2234:
URL: https://github.com/apache/incubator-opendal/pull/2234#issuecomment-1540467628

   > Hi! This change missed the doc here:
   
   Oh, thanks a lot!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org