You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by soralee <gi...@git.apache.org> on 2017/02/07 06:31:12 UTC
[GitHub] zeppelin pull request #1983: [ZEPPELIN-1808] disable shortcut key of window ...
GitHub user soralee opened a pull request:
https://github.com/apache/zeppelin/pull/1983
[ZEPPELIN-1808] disable shortcut key of window created by link this paragraph
### What is this PR for?
If using a `Link this paragraph`, new window works the keyboard shortcut.
Keyboard shortcut should not work in "Link this paragraph" URL.
### What type of PR is it?
[ Improvement ]
### What is the Jira issue?
[ZEPPELIN-1808](https://issues.apache.org/jira/browse/ZEPPELIN-1808)
### How should this be tested?
1. Click `Link this paragraph` or Use `Ctrl+Alt(command)+w` in a paragraph.
2. Use some keyboard shortcut in new window which is created by `Link this paragraph`.
3. Check text and title shape of the paragraph.
### Screenshots (if appropriate)
[ Before ]
* When trying to use keyboard shortcut in new paragraph.
* Text and title are misaligned
[ After ]
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/soralee/zeppelin ZEPPELIN-1808_dont_shortcut
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1983.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1983
----
commit dd563a2efddb0ceec4bd9593dc96a913ab0aa779
Author: soralee <so...@zepl.com>
Date: 2017-02-06T17:15:14Z
[ZEPPELIN-1808] disable shortcut key of window created by link this paragraph
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1983: [ZEPPELIN-1808] disable shortcut key of window ...
Posted by soralee <gi...@git.apache.org>.
GitHub user soralee reopened a pull request:
https://github.com/apache/zeppelin/pull/1983
[ZEPPELIN-1808] disable shortcut key of window created by link this paragraph
### What is this PR for?
If using a `Link this paragraph`, new window works the keyboard shortcut.
Keyboard shortcut should not work in "Link this paragraph" URL.
### What type of PR is it?
[ Improvement ]
### What is the Jira issue?
[ZEPPELIN-1808](https://issues.apache.org/jira/browse/ZEPPELIN-1808)
### How should this be tested?
1. Click `Link this paragraph` or Use `Ctrl+Alt(command)+w` in a paragraph.
2. Use some keyboard shortcut in new window which is created by `Link this paragraph`.
3. Check text and title shape of the paragraph.
### Screenshots (if appropriate)
[ Before ]
* When trying to use keyboard shortcut in new paragraph.
* Text and title are misaligned
[ After ]
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/soralee/zeppelin ZEPPELIN-1808_dont_shortcut
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1983.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1983
----
commit dd563a2efddb0ceec4bd9593dc96a913ab0aa779
Author: soralee <so...@zepl.com>
Date: 2017-02-06T17:15:14Z
[ZEPPELIN-1808] disable shortcut key of window created by link this paragraph
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1983: [ZEPPELIN-1808] disable shortcut key of window created...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1983
Thanks @soralee for the fix.
Tested manually and it works well as expected.
LGTM.
Master branch is little bit different from branch-0.7 so i can not apply this patch to branch-0.7. So, @soralee Can you create separate PR that disables keyboard shortcut for branch-0.7, too?
So the patch can be included in 0.7.1 release.
It's out of this issue scope, but 'Link this paragraph' is designed to user embed a paragraph in the website. So i think it's better not having any boarder or margin.
@soralee what do you think removing border and margin (marked in blue and red arrow) in a separate issue?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1983: [ZEPPELIN-1808] disable shortcut key of window ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1983
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1983: [ZEPPELIN-1808] disable shortcut key of window created...
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/1983
Thanks @Leemoonsoo for taking care of this PR and testing it out :)
Sure, Let me separate and create two issues that are branch-0.7 and shape of window.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1983: [ZEPPELIN-1808] disable shortcut key of window created...
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/1983
@Leemoonsoo Could you review this PR as JIRA issue reporter?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1983: [ZEPPELIN-1808] disable shortcut key of window ...
Posted by soralee <gi...@git.apache.org>.
Github user soralee closed the pull request at:
https://github.com/apache/zeppelin/pull/1983
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1983: [ZEPPELIN-1808] disable shortcut key of window created...
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/1983
Hi @Leemoonsoo,
I opened two issue as your comment (#2045, #2054) so it would be nice if you could check some PRs. Furthermore this CI is green now :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---