You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Daniel Dai (JIRA)" <ji...@apache.org> on 2011/05/04 23:49:03 UTC
[jira] [Created] (PIG-2040) Move classloader from QueryParserDriver
to PigContext
Move classloader from QueryParserDriver to PigContext
-----------------------------------------------------
Key: PIG-2040
URL: https://issues.apache.org/jira/browse/PIG-2040
Project: Pig
Issue Type: Bug
Components: impl
Affects Versions: 0.9.0
Reporter: Daniel Dai
Assignee: Daniel Dai
Fix For: 0.9.0
Attachments: PIG-2040-1.patch
After PIG-1775, mapreduce mode fail. The reason is we move classloader from LogicalPlanBuilder to QueryParserDriver, which will need antlr.jar, however, we don't ship antlr.jar to backend. It is better to move classloader to PigContext.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2040) Move classloader from
QueryParserDriver to PigContext
Posted by "Santhosh Srinivasan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13029081#comment-13029081 ]
Santhosh Srinivasan commented on PIG-2040:
------------------------------------------
I remember a user trying to parse schemas using the Util.parseFromString() method in an UDF. This might require shipping the antlr binaries to the back-end. Will this patch address this issue too?
> Move classloader from QueryParserDriver to PigContext
> -----------------------------------------------------
>
> Key: PIG-2040
> URL: https://issues.apache.org/jira/browse/PIG-2040
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.9.0
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Fix For: 0.9.0
>
> Attachments: PIG-2040-1.patch
>
>
> After PIG-1775, mapreduce mode fail. The reason is we move classloader from LogicalPlanBuilder to QueryParserDriver, which will need antlr.jar, however, we don't ship antlr.jar to backend. It is better to move classloader to PigContext.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2040) Move classloader from QueryParserDriver
to PigContext
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dai updated PIG-2040:
----------------------------
Attachment: PIG-2040-2.patch
> Move classloader from QueryParserDriver to PigContext
> -----------------------------------------------------
>
> Key: PIG-2040
> URL: https://issues.apache.org/jira/browse/PIG-2040
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.9.0
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Fix For: 0.9.0
>
> Attachments: PIG-2040-1.patch, PIG-2040-2.patch
>
>
> After PIG-1775, mapreduce mode fail. The reason is we move classloader from LogicalPlanBuilder to QueryParserDriver, which will need antlr.jar, however, we don't ship antlr.jar to backend. It is better to move classloader to PigContext.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2040) Move classloader from
QueryParserDriver to PigContext
Posted by "Xuefu Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13029058#comment-13029058 ]
Xuefu Zhang commented on PIG-2040:
----------------------------------
+1
> Move classloader from QueryParserDriver to PigContext
> -----------------------------------------------------
>
> Key: PIG-2040
> URL: https://issues.apache.org/jira/browse/PIG-2040
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.9.0
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Fix For: 0.9.0
>
> Attachments: PIG-2040-1.patch
>
>
> After PIG-1775, mapreduce mode fail. The reason is we move classloader from LogicalPlanBuilder to QueryParserDriver, which will need antlr.jar, however, we don't ship antlr.jar to backend. It is better to move classloader to PigContext.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-2040) Move classloader from QueryParserDriver
to PigContext
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dai updated PIG-2040:
----------------------------
Attachment: PIG-2040-1.patch
> Move classloader from QueryParserDriver to PigContext
> -----------------------------------------------------
>
> Key: PIG-2040
> URL: https://issues.apache.org/jira/browse/PIG-2040
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.9.0
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Fix For: 0.9.0
>
> Attachments: PIG-2040-1.patch
>
>
> After PIG-1775, mapreduce mode fail. The reason is we move classloader from LogicalPlanBuilder to QueryParserDriver, which will need antlr.jar, however, we don't ship antlr.jar to backend. It is better to move classloader to PigContext.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2040) Move classloader from
QueryParserDriver to PigContext
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13029539#comment-13029539 ]
Daniel Dai commented on PIG-2040:
---------------------------------
Test-patch:
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
[exec] Please justify why no tests are needed for this patch.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec]
[exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
No new unit test added. This only happens when test in real cluster.
Unit-test:
all pass
> Move classloader from QueryParserDriver to PigContext
> -----------------------------------------------------
>
> Key: PIG-2040
> URL: https://issues.apache.org/jira/browse/PIG-2040
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.9.0
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Fix For: 0.9.0
>
> Attachments: PIG-2040-1.patch
>
>
> After PIG-1775, mapreduce mode fail. The reason is we move classloader from LogicalPlanBuilder to QueryParserDriver, which will need antlr.jar, however, we don't ship antlr.jar to backend. It is better to move classloader to PigContext.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2040) Move classloader from
QueryParserDriver to PigContext
Posted by "Santhosh Srinivasan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13029098#comment-13029098 ]
Santhosh Srinivasan commented on PIG-2040:
------------------------------------------
It did not work back then because javacc was not shipped. Should we consider shipping the parser binaries to allow users to take advantage of utility methods? This can be tracked as a separate issue.
> Move classloader from QueryParserDriver to PigContext
> -----------------------------------------------------
>
> Key: PIG-2040
> URL: https://issues.apache.org/jira/browse/PIG-2040
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.9.0
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Fix For: 0.9.0
>
> Attachments: PIG-2040-1.patch
>
>
> After PIG-1775, mapreduce mode fail. The reason is we move classloader from LogicalPlanBuilder to QueryParserDriver, which will need antlr.jar, however, we don't ship antlr.jar to backend. It is better to move classloader to PigContext.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2040) Move classloader from
QueryParserDriver to PigContext
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13029093#comment-13029093 ]
Daniel Dai commented on PIG-2040:
---------------------------------
bq. I remember a user trying to parse schemas using the Util.parseFromString() method in an UDF. This might require shipping the antlr binaries to the back-end. Will this patch address this issue too?
No, it will not. Seems we need to ship antlr.jar as well. But still put classloader into PigContext is more clear. Also I wonder how Util.parseFromString() works now? We don't ship javacc as well.
> Move classloader from QueryParserDriver to PigContext
> -----------------------------------------------------
>
> Key: PIG-2040
> URL: https://issues.apache.org/jira/browse/PIG-2040
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.9.0
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Fix For: 0.9.0
>
> Attachments: PIG-2040-1.patch
>
>
> After PIG-1775, mapreduce mode fail. The reason is we move classloader from LogicalPlanBuilder to QueryParserDriver, which will need antlr.jar, however, we don't ship antlr.jar to backend. It is better to move classloader to PigContext.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (PIG-2040) Move classloader from
QueryParserDriver to PigContext
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dai resolved PIG-2040.
-----------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Patch committed to both trunk and 0.9 branch.
> Move classloader from QueryParserDriver to PigContext
> -----------------------------------------------------
>
> Key: PIG-2040
> URL: https://issues.apache.org/jira/browse/PIG-2040
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.9.0
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Fix For: 0.9.0
>
> Attachments: PIG-2040-1.patch, PIG-2040-2.patch
>
>
> After PIG-1775, mapreduce mode fail. The reason is we move classloader from LogicalPlanBuilder to QueryParserDriver, which will need antlr.jar, however, we don't ship antlr.jar to backend. It is better to move classloader to PigContext.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-2040) Move classloader from
QueryParserDriver to PigContext
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-2040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13029109#comment-13029109 ]
Daniel Dai commented on PIG-2040:
---------------------------------
Yes, definitely. Actually javacc works since javacc does not need runtime support.
> Move classloader from QueryParserDriver to PigContext
> -----------------------------------------------------
>
> Key: PIG-2040
> URL: https://issues.apache.org/jira/browse/PIG-2040
> Project: Pig
> Issue Type: Bug
> Components: impl
> Affects Versions: 0.9.0
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Fix For: 0.9.0
>
> Attachments: PIG-2040-1.patch
>
>
> After PIG-1775, mapreduce mode fail. The reason is we move classloader from LogicalPlanBuilder to QueryParserDriver, which will need antlr.jar, however, we don't ship antlr.jar to backend. It is better to move classloader to PigContext.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira