You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Sandeep Tata (JIRA)" <ji...@apache.org> on 2009/10/21 01:59:59 UTC
[jira] Created: (CASSANDRA-501) Bootstrap broken in 0.4.1
Bootstrap broken in 0.4.1
-------------------------
Key: CASSANDRA-501
URL: https://issues.apache.org/jira/browse/CASSANDRA-501
Project: Cassandra
Issue Type: Bug
Components: Core
Affects Versions: 0.4
Environment: all
Reporter: Sandeep Tata
Assignee: Sandeep Tata
Fix For: 0.4
Bootstrap fails with NPE in 0.4.1 when you start a node with the -b option
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (CASSANDRA-501) Bootstrap broken in
0.4.1
Posted by "Sandeep Tata (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12768021#action_12768021 ]
Sandeep Tata edited comment on CASSANDRA-501 at 10/21/09 12:09 AM:
-------------------------------------------------------------------
Applicable for 0.4.1, not useful for trunk.
trunk runs:
for (int i=0; i< targets_.length; i++)
{
tokenMetadata_.update(tokens_[i], targets_[i], false);
}
before calling getRangesWithSourceTarget(), so it won't have this problem. We should probably fix the unit test so we catch this in the future.
was (Author: sandeep_tata):
Applicable for 0.4.1, not useful for trunk.
> Bootstrap broken in 0.4.1
> -------------------------
>
> Key: CASSANDRA-501
> URL: https://issues.apache.org/jira/browse/CASSANDRA-501
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.4
> Environment: all
> Reporter: Sandeep Tata
> Assignee: Sandeep Tata
> Fix For: 0.4
>
> Attachments: bootstrapfix-v1.patch
>
>
> Bootstrap fails with NPE in 0.4.1 when you start a node with the -b option
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-501) Bootstrap broken in 0.4.1
Posted by "Sandeep Tata (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sandeep Tata updated CASSANDRA-501:
-----------------------------------
Attachment: bootstrapfix-v1.patch
1. Fixes null token getting passed to Bootstapper
2. Correctly includes new nodes in src-target calculation (changes in tokenMetada for echoing writes probably broke this)
3. Fixed unit test
> Bootstrap broken in 0.4.1
> -------------------------
>
> Key: CASSANDRA-501
> URL: https://issues.apache.org/jira/browse/CASSANDRA-501
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.4
> Environment: all
> Reporter: Sandeep Tata
> Assignee: Sandeep Tata
> Fix For: 0.4
>
> Attachments: bootstrapfix-v1.patch
>
>
> Bootstrap fails with NPE in 0.4.1 when you start a node with the -b option
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-501) Bootstrap broken in 0.4.1
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12772862#action_12772862 ]
Jonathan Ellis commented on CASSANDRA-501:
------------------------------------------
Sandeep, how is testing looking on this?
> Bootstrap broken in 0.4.1
> -------------------------
>
> Key: CASSANDRA-501
> URL: https://issues.apache.org/jira/browse/CASSANDRA-501
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.4
> Environment: all
> Reporter: Sandeep Tata
> Assignee: Sandeep Tata
> Fix For: 0.4
>
> Attachments: bootstrapfix-v1.patch
>
>
> Bootstrap fails with NPE in 0.4.1 when you start a node with the -b option
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-501) Bootstrap broken in 0.4.1
Posted by "Sandeep Tata (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12773106#action_12773106 ]
Sandeep Tata commented on CASSANDRA-501:
----------------------------------------
My 1->2 node tests were fine, I'm waiting to hear from the other team trying this.
If you want to go ahead and commit this for 0.4.2, that's fine. I'll be able to run a bunch of comprehensive tests after Friday, and submit other fixes if needed.
> Bootstrap broken in 0.4.1
> -------------------------
>
> Key: CASSANDRA-501
> URL: https://issues.apache.org/jira/browse/CASSANDRA-501
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.4
> Environment: all
> Reporter: Sandeep Tata
> Assignee: Sandeep Tata
> Fix For: 0.4
>
> Attachments: bootstrapfix-v1.patch
>
>
> Bootstrap fails with NPE in 0.4.1 when you start a node with the -b option
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-501) Bootstrap broken in 0.4.1
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12768297#action_12768297 ]
Jonathan Ellis commented on CASSANDRA-501:
------------------------------------------
I don't follow the reasoning behind cloneTokenEndPointMapIncludingBootstrapNodes. If we include bootstrap-in-progress nodes in the source ranges, we could try to bootstrap from nodes that don't have all the data yet. Better to bootstrap only from the original nodes; if there is overlap w/ existing bootstrapers, then we have some inefficiency, but that is better than not getting all the data.
> Bootstrap broken in 0.4.1
> -------------------------
>
> Key: CASSANDRA-501
> URL: https://issues.apache.org/jira/browse/CASSANDRA-501
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.4
> Environment: all
> Reporter: Sandeep Tata
> Assignee: Sandeep Tata
> Fix For: 0.4
>
> Attachments: bootstrapfix-v1.patch
>
>
> Bootstrap fails with NPE in 0.4.1 when you start a node with the -b option
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.