You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@roller.apache.org by gregh <gr...@ricoh-uk.com> on 2006/08/08 14:54:54 UTC
IfModifiedWeblogPageCacheFilter IllegalArgumentException
Hello,
This code:
if (updateTime != null) {
// convert date (JDK 1.5 workaround)
String date = dateFormatter.format(updateTime);
updateTime = new Date(date);
if (updateTime.compareTo(sinceDate) <= 0) {
mLogger.debug("NOT_MODIFIED " + key);
response.setStatus(HttpServletResponse.SC_NOT_MODIFIED);
return;
}
}
always throws an exception in new Date(date) and never gets to the return,
when using JDK1.5.
Not sure if the filter is doing what it is supposed to when the code is
modified ie updateTime = dateFormatter.parse(date);
Cheers greg.
--
View this message in context: http://www.nabble.com/IfModifiedWeblogPageCacheFilter-IllegalArgumentException-tf2072474s12275.html#a5705791
Sent from the Roller - Dev forum at Nabble.com.
Re: IfModifiedWeblogPageCacheFilter IllegalArgumentException
Posted by Allen Gilliland <al...@sun.com>.
All of the caching and if-modified-since handling is done directly in
the appropriate servlets in 3.0, so you can check out any of the classes
under org.apache.roller.ui.rendering.servlets.*
You are most likely interested in the PageServlet (weblog pages) and
FeedServlet (weblog feeds).
-- Allen
gregh wrote:
> Allen,
> Had a quick look at the 3.0 branch, how is this feature done in 3.0? This
> reduces the db hits considerably in <2.3.
>
> Cheers Greg
Re: IfModifiedWeblogPageCacheFilter IllegalArgumentException
Posted by gregh <gr...@ricoh-uk.com>.
Allen,
Had a quick look at the 3.0 branch, how is this feature done in 3.0? This
reduces the db hits considerably in <2.3.
Cheers Greg
--
View this message in context: http://www.nabble.com/IfModifiedWeblogPageCacheFilter-IllegalArgumentException-tf2072474s12275.html#a5724556
Sent from the Roller - Dev forum at Nabble.com.
Re: IfModifiedWeblogPageCacheFilter IllegalArgumentException
Posted by Anil Gangolli <an...@busybuddha.org>.
People might be running 2.3 for some time, so I'll probably fix it for 2.3
even so.
--a.
----- Original Message -----
From: "Allen Gilliland" <al...@sun.com>
To: <ro...@incubator.apache.org>
Sent: Tuesday, August 08, 2006 9:31 AM
Subject: Re: IfModifiedWeblogPageCacheFilter IllegalArgumentException
> This may be an obsolete issue since all of the old caching filters have
> been removed in Roller 3.0 and replaced with new code. To tell the truth,
> I actually couldn't even figure out why that code was doing that when I
> went to replace it :/
>
> -- Allen
>
>
> Anil Gangolli wrote:
>>
>> I've filed
>> http://opensource.atlassian.com/projects/roller/browse/ROL-1201 based on
>> this e-mail.
>>
>> Watch it if you want to track progress.
>> --a.
>>
>>
>>
>> ----- Original Message ----- From: "gregh" <gr...@ricoh-uk.com>
>> To: <ro...@incubator.apache.org>
>> Sent: Tuesday, August 08, 2006 5:54 AM
>> Subject: IfModifiedWeblogPageCacheFilter IllegalArgumentException
>>
>>
>>>
>>> Hello,
>>>
>>> This code:
>>>
>>> if (updateTime != null) {
>>> // convert date (JDK 1.5 workaround)
>>> String date = dateFormatter.format(updateTime);
>>> updateTime = new Date(date);
>>> if (updateTime.compareTo(sinceDate) <= 0) {
>>> mLogger.debug("NOT_MODIFIED " + key);
>>> response.setStatus(HttpServletResponse.SC_NOT_MODIFIED);
>>> return;
>>> }
>>> }
>>>
>>> always throws an exception in new Date(date) and never gets to the
>>> return,
>>> when using JDK1.5.
>>>
>>> Not sure if the filter is doing what it is supposed to when the code is
>>> modified ie updateTime = dateFormatter.parse(date);
>>>
>>> Cheers greg.
>>> --
>>> View this message in context:
>>> http://www.nabble.com/IfModifiedWeblogPageCacheFilter-IllegalArgumentException-tf2072474s12275.html#a5705791
>>> Sent from the Roller - Dev forum at Nabble.com.
>>>
>>
>
Re: IfModifiedWeblogPageCacheFilter IllegalArgumentException
Posted by Allen Gilliland <al...@sun.com>.
This may be an obsolete issue since all of the old caching filters have
been removed in Roller 3.0 and replaced with new code. To tell the
truth, I actually couldn't even figure out why that code was doing that
when I went to replace it :/
-- Allen
Anil Gangolli wrote:
>
> I've filed
> http://opensource.atlassian.com/projects/roller/browse/ROL-1201 based on
> this e-mail.
>
> Watch it if you want to track progress.
> --a.
>
>
>
> ----- Original Message ----- From: "gregh" <gr...@ricoh-uk.com>
> To: <ro...@incubator.apache.org>
> Sent: Tuesday, August 08, 2006 5:54 AM
> Subject: IfModifiedWeblogPageCacheFilter IllegalArgumentException
>
>
>>
>> Hello,
>>
>> This code:
>>
>> if (updateTime != null) {
>> // convert date (JDK 1.5 workaround)
>> String date = dateFormatter.format(updateTime);
>> updateTime = new Date(date);
>> if (updateTime.compareTo(sinceDate) <= 0) {
>> mLogger.debug("NOT_MODIFIED " + key);
>> response.setStatus(HttpServletResponse.SC_NOT_MODIFIED);
>> return;
>> }
>> }
>>
>> always throws an exception in new Date(date) and never gets to the
>> return,
>> when using JDK1.5.
>>
>> Not sure if the filter is doing what it is supposed to when the code is
>> modified ie updateTime = dateFormatter.parse(date);
>>
>> Cheers greg.
>> --
>> View this message in context:
>> http://www.nabble.com/IfModifiedWeblogPageCacheFilter-IllegalArgumentException-tf2072474s12275.html#a5705791
>>
>> Sent from the Roller - Dev forum at Nabble.com.
>>
>
Re: IfModifiedWeblogPageCacheFilter IllegalArgumentException
Posted by Anil Gangolli <an...@busybuddha.org>.
I've filed http://opensource.atlassian.com/projects/roller/browse/ROL-1201
based on this e-mail.
Watch it if you want to track progress.
--a.
----- Original Message -----
From: "gregh" <gr...@ricoh-uk.com>
To: <ro...@incubator.apache.org>
Sent: Tuesday, August 08, 2006 5:54 AM
Subject: IfModifiedWeblogPageCacheFilter IllegalArgumentException
>
> Hello,
>
> This code:
>
> if (updateTime != null) {
> // convert date (JDK 1.5 workaround)
> String date = dateFormatter.format(updateTime);
> updateTime = new Date(date);
> if (updateTime.compareTo(sinceDate) <= 0) {
> mLogger.debug("NOT_MODIFIED " + key);
> response.setStatus(HttpServletResponse.SC_NOT_MODIFIED);
> return;
> }
> }
>
> always throws an exception in new Date(date) and never gets to the return,
> when using JDK1.5.
>
> Not sure if the filter is doing what it is supposed to when the code is
> modified ie updateTime = dateFormatter.parse(date);
>
> Cheers greg.
> --
> View this message in context:
> http://www.nabble.com/IfModifiedWeblogPageCacheFilter-IllegalArgumentException-tf2072474s12275.html#a5705791
> Sent from the Roller - Dev forum at Nabble.com.
>
Re: IfModifiedWeblogPageCacheFilter IllegalArgumentException
Posted by Anil Gangolli <an...@busybuddha.org>.
Greg:
Note: I've fixed ROL-1201 and ROL-1207 in trunk revision 431060 by
eliminating all of the cruft around formatting in the filters and just
comparing long time values from getTime() which skirts the JDK 1.5 bug (id
5103041) entirely.
Should solve your issue as well if you grab those files.
--a.
----- Original Message -----
From: "Anil Gangolli" <an...@busybuddha.org>
To: <ro...@incubator.apache.org>
Sent: Friday, August 11, 2006 9:19 AM
Subject: Re: IfModifiedWeblogPageCacheFilter IllegalArgumentException
> That's it! Thanks.
>
> BST's the culprit.
>
> When JVM timezone is BST (either from the system or
> from -Duser.timezone=BST), you will get there and the Date(String)
> constructor fails with an IllegalArgumentException.
>
> I'm not sure if header parsing is also failing for you; my guess is yes.
>
> Happens under both Java 1.4 and Java 1.5 runtimes as far as my limited
> testing goes.
>
> I suspect adding dateformatter.setTimeZone(TimeZone.getTimeZone("GMT"))
> before calling format() using it
> will probably fix the issue. I'll look into it later.
>
> You may also be able to avoid this problem by running Tomcat
> adding -Duser.timezone=GMT to your java options, though not sure if this
> is something you want to do.
>
>
> --a.
>
> ----- Original Message -----
> From: "gregh" <gr...@ricoh-uk.com>
> To: <ro...@incubator.apache.org>
> Sent: Friday, August 11, 2006 8:19 AM
> Subject: Re: IfModifiedWeblogPageCacheFilter IllegalArgumentException
>
>
>>
>> Anil,
>>
>> Mozzila/Firefox. The string date = Fri Aug 11 16:11:45 BST 2006
>>
>> Looks like the date format is OK.
>>
>> Cheers Greg
>> --
>> View this message in context:
>> http://www.nabble.com/IfModifiedWeblogPageCacheFilter-IllegalArgumentException-tf2072474s12275.html#a5764136
>> Sent from the Roller - Dev forum at Nabble.com.
>>
>
Re: IfModifiedWeblogPageCacheFilter IllegalArgumentException
Posted by Anil Gangolli <an...@busybuddha.org>.
That's it! Thanks.
BST's the culprit.
When JVM timezone is BST (either from the system or
from -Duser.timezone=BST), you will get there and the Date(String)
constructor fails with an IllegalArgumentException.
I'm not sure if header parsing is also failing for you; my guess is yes.
Happens under both Java 1.4 and Java 1.5 runtimes as far as my limited
testing goes.
I suspect adding dateformatter.setTimeZone(TimeZone.getTimeZone("GMT"))
before calling format() using it
will probably fix the issue. I'll look into it later.
You may also be able to avoid this problem by running Tomcat
adding -Duser.timezone=GMT to your java options, though not sure if this is
something you want to do.
--a.
----- Original Message -----
From: "gregh" <gr...@ricoh-uk.com>
To: <ro...@incubator.apache.org>
Sent: Friday, August 11, 2006 8:19 AM
Subject: Re: IfModifiedWeblogPageCacheFilter IllegalArgumentException
>
> Anil,
>
> Mozzila/Firefox. The string date = Fri Aug 11 16:11:45 BST 2006
>
> Looks like the date format is OK.
>
> Cheers Greg
> --
> View this message in context:
> http://www.nabble.com/IfModifiedWeblogPageCacheFilter-IllegalArgumentException-tf2072474s12275.html#a5764136
> Sent from the Roller - Dev forum at Nabble.com.
>
Re: IfModifiedWeblogPageCacheFilter IllegalArgumentException
Posted by gregh <gr...@ricoh-uk.com>.
Anil,
Mozzila/Firefox. The string date = Fri Aug 11 16:11:45 BST 2006
Looks like the date format is OK.
Cheers Greg
--
View this message in context: http://www.nabble.com/IfModifiedWeblogPageCacheFilter-IllegalArgumentException-tf2072474s12275.html#a5764136
Sent from the Roller - Dev forum at Nabble.com.
Re: IfModifiedWeblogPageCacheFilter IllegalArgumentException
Posted by Anil Gangolli <an...@busybuddha.org>.
Thanks for this info.
One more question. What browser are you using?
--a.
----- Original Message -----
From: "gregh" <gr...@ricoh-uk.com>
To: <ro...@incubator.apache.org>
Sent: Friday, August 11, 2006 2:16 AM
Subject: Re: IfModifiedWeblogPageCacheFilter IllegalArgumentException
>
> Anil,
>
> I have upgraded the runtime , but and am still seeing the error.
> Debugging
> in eclipse Version: 3.1.2
> Build id: M20060118-1600, j2sdk1.4.2_08, Tomcat plugin running
> jdk1.5.0_08.
>
> (As its going away in 3.0 maybe worth ignoring this?)
>
> This is the stack trace:
> java.lang.IllegalArgumentException
> at java.util.Date.parse(Date.java:595)
> at java.util.Date.<init>(Date.java:255)
> at
> org.apache.roller.presentation.filters.IfModifiedWeblogPageCacheFilter.doFilter(IfModifiedWeblogPageCacheFilter.java:138)
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:202)
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173)
> at
> org.apache.roller.presentation.filters.RefererFilter.doFilter(RefererFilter.java:186)
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:202)
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173)
> at
> org.apache.roller.presentation.filters.PersistenceSessionFilter.doFilter(PersistenceSessionFilter.java:60)
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:202)
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173)
> at
> org.acegisecurity.util.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:292)
> at
> org.acegisecurity.intercept.web.FilterSecurityInterceptor.invoke(FilterSecurityInterceptor.java:108)
> at
> org.acegisecurity.intercept.web.SecurityEnforcementFilter.doFilter(SecurityEnforcementFilter.java:197)
> at
> org.acegisecurity.util.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:303)
> at
> org.acegisecurity.providers.anonymous.AnonymousProcessingFilter.doFilter(AnonymousProcessingFilter.java:143)
> at
> org.acegisecurity.util.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:303)
> at
> org.acegisecurity.wrapper.SecurityContextHolderAwareRequestFilter.doFilter(SecurityContextHolderAwareRequestFilter.java:50)
> at
> org.acegisecurity.util.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:303)
> at
> org.acegisecurity.securechannel.ChannelProcessingFilter.doFilter(ChannelProcessingFilter.java:168)
> at
> org.acegisecurity.util.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:303)
> at
> org.acegisecurity.ui.rememberme.RememberMeProcessingFilter.doFilter(RememberMeProcessingFilter.java:154)
> at
> org.acegisecurity.util.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:303)
> at
> org.acegisecurity.ui.AbstractProcessingFilter.doFilter(AbstractProcessingFilter.java:246)
> at
> org.acegisecurity.util.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:303)
> at
> org.acegisecurity.context.HttpSessionContextIntegrationFilter.doFilter(HttpSessionContextIntegrationFilter.java:220)
> at
> org.acegisecurity.util.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:303)
> at
> org.acegisecurity.util.FilterChainProxy.doFilter(FilterChainProxy.java:173)
> at
> org.acegisecurity.util.FilterToBeanProxy.doFilter(FilterToBeanProxy.java:120)
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:202)
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173)
> at
> org.apache.roller.presentation.filters.SchemeEnforcementFilter.doFilter(SchemeEnforcementFilter.java:121)
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:202)
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173)
> at
> org.apache.roller.presentation.filters.CharEncodingFilter.doFilter(CharEncodingFilter.java:104)
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:202)
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173)
> at
> org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:213)
> at
> org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:178)
> at
> org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:126)
> at
> org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:105)
> at
> org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:107)
> at
> org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:148)
> at
> org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:869)
> at
> org.apache.coyote.http11.Http11BaseProtocol$Http11ConnectionHandler.processConnection(Http11BaseProtocol.java:664)
> at
> org.apache.tomcat.util.net.PoolTcpEndpoint.processSocket(PoolTcpEndpoint.java:527)
> at
> org.apache.tomcat.util.net.LeaderFollowerWorkerThread.runIt(LeaderFollowerWorkerThread.java:80)
> at
> org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:684)
> at java.lang.Thread.run(Thread.java:595)
> --
> View this message in context:
> http://www.nabble.com/IfModifiedWeblogPageCacheFilter-IllegalArgumentException-tf2072474s12275.html#a5759186
> Sent from the Roller - Dev forum at Nabble.com.
>
Re: IfModifiedWeblogPageCacheFilter IllegalArgumentException
Posted by gregh <gr...@ricoh-uk.com>.
Anil,
I have upgraded the runtime , but and am still seeing the error. Debugging
in eclipse Version: 3.1.2
Build id: M20060118-1600, j2sdk1.4.2_08, Tomcat plugin running jdk1.5.0_08.
(As its going away in 3.0 maybe worth ignoring this?)
This is the stack trace:
java.lang.IllegalArgumentException
at java.util.Date.parse(Date.java:595)
at java.util.Date.<init>(Date.java:255)
at
org.apache.roller.presentation.filters.IfModifiedWeblogPageCacheFilter.doFilter(IfModifiedWeblogPageCacheFilter.java:138)
at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:202)
at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173)
at
org.apache.roller.presentation.filters.RefererFilter.doFilter(RefererFilter.java:186)
at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:202)
at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173)
at
org.apache.roller.presentation.filters.PersistenceSessionFilter.doFilter(PersistenceSessionFilter.java:60)
at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:202)
at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173)
at
org.acegisecurity.util.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:292)
at
org.acegisecurity.intercept.web.FilterSecurityInterceptor.invoke(FilterSecurityInterceptor.java:108)
at
org.acegisecurity.intercept.web.SecurityEnforcementFilter.doFilter(SecurityEnforcementFilter.java:197)
at
org.acegisecurity.util.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:303)
at
org.acegisecurity.providers.anonymous.AnonymousProcessingFilter.doFilter(AnonymousProcessingFilter.java:143)
at
org.acegisecurity.util.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:303)
at
org.acegisecurity.wrapper.SecurityContextHolderAwareRequestFilter.doFilter(SecurityContextHolderAwareRequestFilter.java:50)
at
org.acegisecurity.util.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:303)
at
org.acegisecurity.securechannel.ChannelProcessingFilter.doFilter(ChannelProcessingFilter.java:168)
at
org.acegisecurity.util.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:303)
at
org.acegisecurity.ui.rememberme.RememberMeProcessingFilter.doFilter(RememberMeProcessingFilter.java:154)
at
org.acegisecurity.util.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:303)
at
org.acegisecurity.ui.AbstractProcessingFilter.doFilter(AbstractProcessingFilter.java:246)
at
org.acegisecurity.util.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:303)
at
org.acegisecurity.context.HttpSessionContextIntegrationFilter.doFilter(HttpSessionContextIntegrationFilter.java:220)
at
org.acegisecurity.util.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:303)
at
org.acegisecurity.util.FilterChainProxy.doFilter(FilterChainProxy.java:173)
at
org.acegisecurity.util.FilterToBeanProxy.doFilter(FilterToBeanProxy.java:120)
at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:202)
at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173)
at
org.apache.roller.presentation.filters.SchemeEnforcementFilter.doFilter(SchemeEnforcementFilter.java:121)
at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:202)
at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173)
at
org.apache.roller.presentation.filters.CharEncodingFilter.doFilter(CharEncodingFilter.java:104)
at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:202)
at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:173)
at
org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:213)
at
org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:178)
at
org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:126)
at
org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:105)
at
org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:107)
at
org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:148)
at
org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:869)
at
org.apache.coyote.http11.Http11BaseProtocol$Http11ConnectionHandler.processConnection(Http11BaseProtocol.java:664)
at
org.apache.tomcat.util.net.PoolTcpEndpoint.processSocket(PoolTcpEndpoint.java:527)
at
org.apache.tomcat.util.net.LeaderFollowerWorkerThread.runIt(LeaderFollowerWorkerThread.java:80)
at
org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:684)
at java.lang.Thread.run(Thread.java:595)
--
View this message in context: http://www.nabble.com/IfModifiedWeblogPageCacheFilter-IllegalArgumentException-tf2072474s12275.html#a5759186
Sent from the Roller - Dev forum at Nabble.com.
Re: IfModifiedWeblogPageCacheFilter IllegalArgumentException
Posted by Anil Gangolli <an...@busybuddha.org>.
I've commented here:
http://opensource.atlassian.com/projects/roller/browse/ROL-1201
If you want to watch progress/comment further please do so there.
--a.
----- Original Message -----
From: "gregh" <gr...@ricoh-uk.com>
To: <ro...@incubator.apache.org>
Sent: Tuesday, August 08, 2006 9:09 AM
Subject: Re: IfModifiedWeblogPageCacheFilter IllegalArgumentException
>
> Anil,
>
> missed of Fedora cor 4 (linux).
> It looks as though it throws an exception, but is caught by the
> IllegalArgumentException, which in turn does not log any errors.
>
> Cheers Greg
> --
> View this message in context:
> http://www.nabble.com/IfModifiedWeblogPageCacheFilter-IllegalArgumentException-tf2072474s12275.html#a5709781
> Sent from the Roller - Dev forum at Nabble.com.
>
Re: IfModifiedWeblogPageCacheFilter IllegalArgumentException
Posted by Anil Gangolli <an...@busybuddha.org>.
My suggestion is to try upgrading to JDK 1.5.0_07 and see if you can still
reproduce.
--a.
----- Original Message -----
From: "gregh" <gr...@ricoh-uk.com>
To: <ro...@incubator.apache.org>
Sent: Tuesday, August 08, 2006 9:09 AM
Subject: Re: IfModifiedWeblogPageCacheFilter IllegalArgumentException
>
> Anil,
>
> missed of Fedora cor 4 (linux).
> It looks as though it throws an exception, but is caught by the
> IllegalArgumentException, which in turn does not log any errors.
>
> Cheers Greg
> --
> View this message in context:
> http://www.nabble.com/IfModifiedWeblogPageCacheFilter-IllegalArgumentException-tf2072474s12275.html#a5709781
> Sent from the Roller - Dev forum at Nabble.com.
>
Re: IfModifiedWeblogPageCacheFilter IllegalArgumentException
Posted by gregh <gr...@ricoh-uk.com>.
Anil,
missed of Fedora cor 4 (linux).
It looks as though it throws an exception, but is caught by the
IllegalArgumentException, which in turn does not log any errors.
Cheers Greg
--
View this message in context: http://www.nabble.com/IfModifiedWeblogPageCacheFilter-IllegalArgumentException-tf2072474s12275.html#a5709781
Sent from the Roller - Dev forum at Nabble.com.
Re: IfModifiedWeblogPageCacheFilter IllegalArgumentException
Posted by gregh <gr...@ricoh-uk.com>.
Anil,
java version "1.5.0_05"
Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_05-b05)
Java HotSpot(TM) Client VM (build 1.5.0_05-b05, mixed mode, sharing)
Version 2.3, btw there are other filters with the same line of code.
--
View this message in context: http://www.nabble.com/IfModifiedWeblogPageCacheFilter-IllegalArgumentException-tf2072474s12275.html#a5708766
Sent from the Roller - Dev forum at Nabble.com.
Re: IfModifiedWeblogPageCacheFilter IllegalArgumentException
Posted by Anil Gangolli <an...@busybuddha.org>.
Greg, can you tell me the full version info for JDK 1.5 version you are
running? Also, what OS are you on?
--a.
----- Original Message -----
From: "gregh" <gr...@ricoh-uk.com>
To: <ro...@incubator.apache.org>
Sent: Tuesday, August 08, 2006 5:54 AM
Subject: IfModifiedWeblogPageCacheFilter IllegalArgumentException
>
> Hello,
>
> This code:
>
> if (updateTime != null) {
> // convert date (JDK 1.5 workaround)
> String date = dateFormatter.format(updateTime);
> updateTime = new Date(date);
> if (updateTime.compareTo(sinceDate) <= 0) {
> mLogger.debug("NOT_MODIFIED " + key);
> response.setStatus(HttpServletResponse.SC_NOT_MODIFIED);
> return;
> }
> }
>
> always throws an exception in new Date(date) and never gets to the return,
> when using JDK1.5.
>
> Not sure if the filter is doing what it is supposed to when the code is
> modified ie updateTime = dateFormatter.parse(date);
>
> Cheers greg.
> --
> View this message in context:
> http://www.nabble.com/IfModifiedWeblogPageCacheFilter-IllegalArgumentException-tf2072474s12275.html#a5705791
> Sent from the Roller - Dev forum at Nabble.com.
>