You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2014/03/22 00:41:06 UTC
Review Request 19556: Added utility functions in stout to return MAC
addresses.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19556/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Ben Mahler, and Ian Downes.
Repository: mesos-git
Description
-------
See summary.
Diffs
-----
3rdparty/libprocess/3rdparty/Makefile.am 8493155
3rdparty/libprocess/3rdparty/stout/Makefile.am df149dd
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp b3d46d6
3rdparty/libprocess/3rdparty/stout/tests/net_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/19556/diff/
Testing
-------
make check on both OSX and Linux
ALso, manually verified with the output from ifconfig/ip link show
Thanks,
Jie Yu
Re: Review Request 19556: Added utility functions in stout to return MAC
addresses.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19556/#review38370
-----------------------------------------------------------
Bad patch!
Reviews applied: [19556]
Failed command: make -j3 check GTEST_FILTER='' >/dev/null
Error:
ev.c:1531:31: warning: 'ev_default_loop_ptr' initialized and declared 'extern' [enabled by default]
ev.c: In function 'evpipe_write':
ev.c:2160:17: warning: ignoring return value of 'write', declared with attribute warn_unused_result [-Wunused-result]
ev.c:2172:17: warning: ignoring return value of 'write', declared with attribute warn_unused_result [-Wunused-result]
ev.c: In function 'pipecb':
ev.c:2193:16: warning: ignoring return value of 'read', declared with attribute warn_unused_result [-Wunused-result]
ev.c:2207:16: warning: ignoring return value of 'read', declared with attribute warn_unused_result [-Wunused-result]
In file included from /usr/include/c++/4.6/ext/hash_set:61:0,
from src/glog/stl_logging.h:54,
from src/stl_logging_unittest.cc:34:
/usr/include/c++/4.6/backward/backward_warning.h:33:2: warning: #warning This file includes at least one deprecated or antiquated header which may be removed without further notice at a future date. Please use a non-deprecated interface with equivalent functionality instead. For a listing of replacement headers and interfaces, consult the file backward_warning.h. To disable this warning use -Wno-deprecated. [-Wcpp]
In file included from src/utilities.h:73:0,
from src/googletest.h:38,
from src/stl_logging_unittest.cc:48:
src/base/mutex.h:137:0: warning: "_XOPEN_SOURCE" redefined [enabled by default]
/usr/include/features.h:166:0: note: this is the location of the previous definition
warning: no files found matching 'Makefile' under directory 'docs'
warning: no files found matching 'indexsidebar.html' under directory 'docs'
zip_safe flag not set; analyzing archive contents...
WARNING: '.' not a valid package name; please use only.-separated package names in setup.py
package init file 'src/__init__.py' not found (or not a regular file)
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for Ada/C/ObjC but not for C++ [enabled by default]
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for Ada/C/ObjC but not for C++ [enabled by default]
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for Ada/C/ObjC but not for C++ [enabled by default]
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for Ada/C/ObjC but not for C++ [enabled by default]
cc1plus: warning: command line option '-Wstrict-prototypes' is valid for Ada/C/ObjC but not for C++ [enabled by default]
./.libs/libmesos_no_3rdparty.a(libmesos_no_3rdparty_la-detector.o): In function `net::operator<<(std::basic_ostream<char, std::char_traits<char> >&, net::MAC const&)':
/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src/../3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp:201: multiple definition of `net::operator<<(std::basic_ostream<char, std::char_traits<char> >&, net::MAC const&)'
./.libs/libmesos_no_3rdparty.a(libmesos_no_3rdparty_la-local.o):/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src/../3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp:201: first defined here
./.libs/libmesos_no_3rdparty.a(libmesos_no_3rdparty_la-http.o): In function `net::operator<<(std::basic_ostream<char, std::char_traits<char> >&, net::MAC const&)':
/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src/../3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp:201: multiple definition of `net::operator<<(std::basic_ostream<char, std::char_traits<char> >&, net::MAC const&)'
./.libs/libmesos_no_3rdparty.a(libmesos_no_3rdparty_la-local.o):/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src/../3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp:201: first defined here
./.libs/libmesos_no_3rdparty.a(libmesos_no_3rdparty_la-master.o): In function `net::operator<<(std::basic_ostream<char, std::char_traits<char> >&, net::MAC const&)':
/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src/../3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp:201: multiple definition of `net::operator<<(std::basic_ostream<char, std::char_traits<char> >&, net::MAC const&)'
./.libs/libmesos_no_3rdparty.a(libmesos_no_3rdparty_la-local.o):/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src/../3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp:201: first defined here
./.libs/libmesos_no_3rdparty.a(libmesos_no_3rdparty_la-slave.o): In function `net::operator<<(std::basic_ostream<char, std::char_traits<char> >&, net::MAC const&)':
/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src/../3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp:201: multiple definition of `net::operator<<(std::basic_ostream<char, std::char_traits<char> >&, net::MAC const&)'
./.libs/libmesos_no_3rdparty.a(libmesos_no_3rdparty_la-local.o):/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src/../3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp:201: first defined here
./.libs/libmesos_no_3rdparty.a(lt2-libmesos_no_3rdparty_la-http.o): In function `net::operator<<(std::basic_ostream<char, std::char_traits<char> >&, net::MAC const&)':
/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src/../3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp:201: multiple definition of `net::operator<<(std::basic_ostream<char, std::char_traits<char> >&, net::MAC const&)'
./.libs/libmesos_no_3rdparty.a(libmesos_no_3rdparty_la-local.o):/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src/../3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp:201: first defined here
./.libs/libmesos_no_3rdparty.a(libmesos_no_3rdparty_la-containerizer.o): In function `net::operator<<(std::basic_ostream<char, std::char_traits<char> >&, net::MAC const&)':
/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src/../3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp:201: multiple definition of `net::operator<<(std::basic_ostream<char, std::char_traits<char> >&, net::MAC const&)'
./.libs/libmesos_no_3rdparty.a(libmesos_no_3rdparty_la-local.o):/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src/../3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp:201: first defined here
./.libs/libmesos_no_3rdparty.a(libmesos_no_3rdparty_la-mesos_containerizer.o): In function `net::operator<<(std::basic_ostream<char, std::char_traits<char> >&, net::MAC const&)':
/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src/../3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp:201: multiple definition of `net::operator<<(std::basic_ostream<char, std::char_traits<char> >&, net::MAC const&)'
./.libs/libmesos_no_3rdparty.a(libmesos_no_3rdparty_la-local.o):/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src/../3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp:201: first defined here
./.libs/libmesos_no_3rdparty.a(libmesos_no_3rdparty_la-status_update_manager.o): In function `net::operator<<(std::basic_ostream<char, std::char_traits<char> >&, net::MAC const&)':
/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src/../3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp:201: multiple definition of `net::operator<<(std::basic_ostream<char, std::char_traits<char> >&, net::MAC const&)'
./.libs/libmesos_no_3rdparty.a(libmesos_no_3rdparty_la-local.o):/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src/../3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp:201: first defined here
./.libs/libmesos_no_3rdparty.a(libmesos_no_3rdparty_la-exec.o): In function `net::operator<<(std::basic_ostream<char, std::char_traits<char> >&, net::MAC const&)':
/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src/../3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp:201: multiple definition of `net::operator<<(std::basic_ostream<char, std::char_traits<char> >&, net::MAC const&)'
./.libs/libmesos_no_3rdparty.a(libmesos_no_3rdparty_la-local.o):/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src/../3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp:201: first defined here
../3rdparty/libprocess/.libs/libprocess.a(libprocess_la-process.o): In function `net::operator<<(std::basic_ostream<char, std::char_traits<char> >&, net::MAC const&)':
/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/./3rdparty/stout/include/stout/net.hpp:201: multiple definition of `net::operator<<(std::basic_ostream<char, std::char_traits<char> >&, net::MAC const&)'
./.libs/libmesos_no_3rdparty.a(libmesos_no_3rdparty_la-local.o):/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src/../3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp:201: first defined here
collect2: ld returned 1 exit status
make[2]: *** [libmesos.la] Error 1
make[2]: *** Waiting for unfinished jobs....
/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src/.libs/libmesos_no_3rdparty.a(libmesos_no_3rdparty_la-detector.o): In function `net::operator<<(std::basic_ostream<char, std::char_traits<char> >&, net::MAC const&)':
/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src/../3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp:201: multiple definition of `net::operator<<(std::basic_ostream<char, std::char_traits<char> >&, net::MAC const&)'
/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src/.libs/libmesos_no_3rdparty.a(libmesos_no_3rdparty_la-local.o):/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src/../3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp:201: first defined here
/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src/.libs/libmesos_no_3rdparty.a(libmesos_no_3rdparty_la-master.o): In function `net::operator<<(std::basic_ostream<char, std::char_traits<char> >&, net::MAC const&)':
/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src/../3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp:201: multiple definition of `net::operator<<(std::basic_ostream<char, std::char_traits<char> >&, net::MAC const&)'
/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src/.libs/libmesos_no_3rdparty.a(libmesos_no_3rdparty_la-local.o):/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src/../3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp:201: first defined here
/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src/.libs/libmesos_no_3rdparty.a(libmesos_no_3rdparty_la-slave.o): In function `net::operator<<(std::basic_ostream<char, std::char_traits<char> >&, net::MAC const&)':
/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src/../3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp:201: multiple definition of `net::operator<<(std::basic_ostream<char, std::char_traits<char> >&, net::MAC const&)'
/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src/.libs/libmesos_no_3rdparty.a(libmesos_no_3rdparty_la-local.o):/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src/../3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp:201: first defined here
/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src/.libs/libmesos_no_3rdparty.a(lt2-libmesos_no_3rdparty_la-http.o): In function `net::operator<<(std::basic_ostream<char, std::char_traits<char> >&, net::MAC const&)':
/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src/../3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp:201: multiple definition of `net::operator<<(std::basic_ostream<char, std::char_traits<char> >&, net::MAC const&)'
/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src/.libs/libmesos_no_3rdparty.a(libmesos_no_3rdparty_la-local.o):/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src/../3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp:201: first defined here
/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src/.libs/libmesos_no_3rdparty.a(libmesos_no_3rdparty_la-containerizer.o): In function `net::operator<<(std::basic_ostream<char, std::char_traits<char> >&, net::MAC const&)':
/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src/../3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp:201: multiple definition of `net::operator<<(std::basic_ostream<char, std::char_traits<char> >&, net::MAC const&)'
/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src/.libs/libmesos_no_3rdparty.a(libmesos_no_3rdparty_la-local.o):/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src/../3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp:201: first defined here
/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src/.libs/libmesos_no_3rdparty.a(libmesos_no_3rdparty_la-mesos_containerizer.o): In function `net::operator<<(std::basic_ostream<char, std::char_traits<char> >&, net::MAC const&)':
/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src/../3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp:201: multiple definition of `net::operator<<(std::basic_ostream<char, std::char_traits<char> >&, net::MAC const&)'
/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src/.libs/libmesos_no_3rdparty.a(libmesos_no_3rdparty_la-local.o):/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src/../3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp:201: first defined here
/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src/.libs/libmesos_no_3rdparty.a(libmesos_no_3rdparty_la-status_update_manager.o): In function `net::operator<<(std::basic_ostream<char, std::char_traits<char> >&, net::MAC const&)':
/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src/../3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp:201: multiple definition of `net::operator<<(std::basic_ostream<char, std::char_traits<char> >&, net::MAC const&)'
/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src/.libs/libmesos_no_3rdparty.a(libmesos_no_3rdparty_la-local.o):/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src/../3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp:201: first defined here
/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src/.libs/libmesos_no_3rdparty.a(libmesos_no_3rdparty_la-exec.o): In function `net::operator<<(std::basic_ostream<char, std::char_traits<char> >&, net::MAC const&)':
/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src/../3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp:201: multiple definition of `net::operator<<(std::basic_ostream<char, std::char_traits<char> >&, net::MAC const&)'
/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src/.libs/libmesos_no_3rdparty.a(libmesos_no_3rdparty_la-local.o):/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src/../3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp:201: first defined here
/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src/.libs/libmesos_no_3rdparty.a(libmesos_no_3rdparty_la-http.o): In function `net::operator<<(std::basic_ostream<char, std::char_traits<char> >&, net::MAC const&)':
/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src/../3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp:201: multiple definition of `net::operator<<(std::basic_ostream<char, std::char_traits<char> >&, net::MAC const&)'
/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src/.libs/libmesos_no_3rdparty.a(libmesos_no_3rdparty_la-local.o):/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src/../3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp:201: first defined here
/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/.libs/libprocess.a(libprocess_la-process.o): In function `net::operator<<(std::basic_ostream<char, std::char_traits<char> >&, net::MAC const&)':
/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/3rdparty/libprocess/./3rdparty/stout/include/stout/net.hpp:201: multiple definition of `net::operator<<(std::basic_ostream<char, std::char_traits<char> >&, net::MAC const&)'
/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src/.libs/libmesos_no_3rdparty.a(libmesos_no_3rdparty_la-local.o):/home/jenkins/jenkins-slave/workspace/mesos-reviewbot/src/../3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp:201: first defined here
collect2: ld returned 1 exit status
error: command 'g++' failed with exit status 1
make[2]: *** [python/dist/mesos-0.19.0-py2.7-linux-x86_64.egg] Error 1
make[1]: *** [check] Error 2
make: *** [check-recursive] Error 1
- Mesos ReviewBot
On March 24, 2014, 8:45 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19556/
> -----------------------------------------------------------
>
> (Updated March 24, 2014, 8:45 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Chi Zhang, Ian Downes, Vinod Kone, and Cong Wang.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am 8493155
> 3rdparty/libprocess/3rdparty/stout/Makefile.am df149dd
> 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp b3d46d6
> 3rdparty/libprocess/3rdparty/stout/tests/net_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/19556/diff/
>
>
> Testing
> -------
>
> make check on both OSX and Linux
>
> ALso, manually verified with the output from ifconfig/ip link show
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 19556: Added utility functions in stout to return MAC
addresses.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19556/
-----------------------------------------------------------
(Updated March 25, 2014, 5:31 a.m.)
Review request for mesos, Benjamin Hindman, Chi Zhang, Ian Downes, Vinod Kone, and Cong Wang.
Changes
-------
Dominic's comments. Rebased.
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/Makefile.am 8493155
3rdparty/libprocess/3rdparty/stout/Makefile.am df149dd
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp b3d46d6
3rdparty/libprocess/3rdparty/stout/tests/net_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/19556/diff/
Testing
-------
make check on both OSX and Linux
ALso, manually verified with the output from ifconfig/ip link show
Thanks,
Jie Yu
Re: Review Request 19556: Added utility functions in stout to return MAC
addresses.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19556/
-----------------------------------------------------------
(Updated March 25, 2014, 5:29 a.m.)
Review request for mesos, Benjamin Hindman, Chi Zhang, Ian Downes, Vinod Kone, and Cong Wang.
Changes
-------
Vinod's comments.
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/Makefile.am 8493155
3rdparty/libprocess/3rdparty/stout/Makefile.am df149dd
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp b3d46d6
3rdparty/libprocess/3rdparty/stout/tests/net_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/19556/diff/
Testing
-------
make check on both OSX and Linux
ALso, manually verified with the output from ifconfig/ip link show
Thanks,
Jie Yu
Re: Review Request 19556: Added utility functions in stout to return MAC
addresses.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19556/#review38399
-----------------------------------------------------------
Patch looks great!
Reviews applied: [19556]
All tests passed.
- Mesos ReviewBot
On March 24, 2014, 10:16 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19556/
> -----------------------------------------------------------
>
> (Updated March 24, 2014, 10:16 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Chi Zhang, Ian Downes, Vinod Kone, and Cong Wang.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am 8493155
> 3rdparty/libprocess/3rdparty/stout/Makefile.am df149dd
> 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp b3d46d6
> 3rdparty/libprocess/3rdparty/stout/tests/net_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/19556/diff/
>
>
> Testing
> -------
>
> make check on both OSX and Linux
>
> ALso, manually verified with the output from ifconfig/ip link show
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 19556: Added utility functions in stout to return MAC
addresses.
Posted by Jie Yu <yu...@gmail.com>.
> On March 25, 2014, 12:42 a.m., Vinod Kone wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp, line 172
> > <https://reviews.apache.org/r/19556/diff/4/?file=534342#file534342line172>
> >
> > Do you expect this to be used outside tests?
Yes, it will be used when we create filters (match a given MAC address).
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19556/#review38398
-----------------------------------------------------------
On March 24, 2014, 10:16 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19556/
> -----------------------------------------------------------
>
> (Updated March 24, 2014, 10:16 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Chi Zhang, Ian Downes, Vinod Kone, and Cong Wang.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am 8493155
> 3rdparty/libprocess/3rdparty/stout/Makefile.am df149dd
> 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp b3d46d6
> 3rdparty/libprocess/3rdparty/stout/tests/net_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/19556/diff/
>
>
> Testing
> -------
>
> make check on both OSX and Linux
>
> ALso, manually verified with the output from ifconfig/ip link show
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 19556: Added utility functions in stout to return MAC
addresses.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19556/#review38398
-----------------------------------------------------------
Ship it!
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp
<https://reviews.apache.org/r/19556/#comment70525>
kill new line.
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp
<https://reviews.apache.org/r/19556/#comment70530>
Do you expect this to be used outside tests?
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp
<https://reviews.apache.org/r/19556/#comment70526>
Put each argument on its own line.
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp
<https://reviews.apache.org/r/19556/#comment70529>
Kill the TODOO?
- Vinod Kone
On March 24, 2014, 10:16 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19556/
> -----------------------------------------------------------
>
> (Updated March 24, 2014, 10:16 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Chi Zhang, Ian Downes, Vinod Kone, and Cong Wang.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am 8493155
> 3rdparty/libprocess/3rdparty/stout/Makefile.am df149dd
> 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp b3d46d6
> 3rdparty/libprocess/3rdparty/stout/tests/net_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/19556/diff/
>
>
> Testing
> -------
>
> make check on both OSX and Linux
>
> ALso, manually verified with the output from ifconfig/ip link show
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 19556: Added utility functions in stout to return MAC
addresses.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19556/
-----------------------------------------------------------
(Updated March 24, 2014, 10:16 p.m.)
Review request for mesos, Benjamin Hindman, Chi Zhang, Ian Downes, Vinod Kone, and Cong Wang.
Changes
-------
Fixed the linking issue by adding inline.
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/Makefile.am 8493155
3rdparty/libprocess/3rdparty/stout/Makefile.am df149dd
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp b3d46d6
3rdparty/libprocess/3rdparty/stout/tests/net_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/19556/diff/
Testing
-------
make check on both OSX and Linux
ALso, manually verified with the output from ifconfig/ip link show
Thanks,
Jie Yu
Re: Review Request 19556: Added utility functions in stout to return MAC
addresses.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19556/
-----------------------------------------------------------
(Updated March 24, 2014, 8:45 p.m.)
Review request for mesos, Benjamin Hindman, Chi Zhang, Ian Downes, Vinod Kone, and Cong Wang.
Changes
-------
Returned MAC struct instead of the string format.
Repository: mesos-git
Description
-------
See summary.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/Makefile.am 8493155
3rdparty/libprocess/3rdparty/stout/Makefile.am df149dd
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp b3d46d6
3rdparty/libprocess/3rdparty/stout/tests/net_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/19556/diff/
Testing
-------
make check on both OSX and Linux
ALso, manually verified with the output from ifconfig/ip link show
Thanks,
Jie Yu
Re: Review Request 19556: Added utility functions in stout to return MAC
addresses.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19556/#review38245
-----------------------------------------------------------
Patch looks great!
Reviews applied: [19556]
All tests passed.
- Mesos ReviewBot
On March 21, 2014, 11:41 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19556/
> -----------------------------------------------------------
>
> (Updated March 21, 2014, 11:41 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Ian Downes.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am 8493155
> 3rdparty/libprocess/3rdparty/stout/Makefile.am df149dd
> 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp b3d46d6
> 3rdparty/libprocess/3rdparty/stout/tests/net_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/19556/diff/
>
>
> Testing
> -------
>
> make check on both OSX and Linux
>
> ALso, manually verified with the output from ifconfig/ip link show
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 19556: Added utility functions in stout to return MAC
addresses.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19556/#review38349
-----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp
<https://reviews.apache.org/r/19556/#comment70432>
reads better as:
if (!found) {
return Error(...);
}
return None();
- Dominic Hamon
On March 21, 2014, 4:41 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19556/
> -----------------------------------------------------------
>
> (Updated March 21, 2014, 4:41 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Ian Downes.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am 8493155
> 3rdparty/libprocess/3rdparty/stout/Makefile.am df149dd
> 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp b3d46d6
> 3rdparty/libprocess/3rdparty/stout/tests/net_tests.cpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/19556/diff/
>
>
> Testing
> -------
>
> make check on both OSX and Linux
>
> ALso, manually verified with the output from ifconfig/ip link show
>
>
> Thanks,
>
> Jie Yu
>
>