You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/09/13 19:08:50 UTC

[GitHub] [iceberg] yyanyy commented on issue #2532: Add metadata tables tests to make sure they don't break when reading different versions of tables

yyanyy commented on issue #2532:
URL: https://github.com/apache/iceberg/issues/2532#issuecomment-918493847


   @itachi-sharingan welcome to the community! Your understanding is correct. For creating iceberg table, the manifest/data files are not needed as the input since they should be eventually linked from the table metadata file, so such relationship should be preserved from the table metadata object and the manifest files in the resources folder. 
   
   For finding the files introduced, I think https://iceberg.apache.org/spec/#version-2 this could be a good place to check what's strictly required for v1 vs. v2; you can also create a v1 table (follow code path as in https://github.com/apache/iceberg/pull/2887 to find out the setting) and use the created files as starting point. I think we can have such setup for both v1 and v2 tables, so that in future when v3 is introduced we can continue to have this safety guard. 
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org