You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/01/08 19:30:36 UTC

[GitHub] [incubator-superset] villebro commented on a change in pull request #8935: [fix] Enforce the QueryResult.df to be a pandas.DataFrame object

villebro commented on a change in pull request #8935: [fix] Enforce the QueryResult.df to be a pandas.DataFrame object
URL: https://github.com/apache/incubator-superset/pull/8935#discussion_r364403331
 
 

 ##########
 File path: superset/viz.py
 ##########
 @@ -439,11 +439,7 @@ def get_df_payload(self, query_obj=None, **kwargs):
                 and self.status != utils.QueryStatus.FAILED
             ):
                 try:
-                    cache_value = dict(
-                        dttm=cached_dttm,
-                        df=df if df is not None else None,
 
 Review comment:
   ![image](https://user-images.githubusercontent.com/33317356/72008984-a03e3480-325d-11ea-86ea-924887888bd1.png)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org