You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/07/28 16:14:29 UTC

[GitHub] [doris] luozenglin opened a new pull request, #11316: [fix] Fix the query result error caused by the grouping sets statemen…

luozenglin opened a new pull request, #11316:
URL: https://github.com/apache/doris/pull/11316

   …t grouping as an expression
   
   Push the expression down to the repeat node.
   
   # Proposed changes
   
   Issue Number: close #4427
   
   ## Problem Summary:
   
   ## Checklist(Required)
   
   1. Type of your changes:
       - [ ] Improvement
       - [x] Fix
       - [ ] Feature-WIP
       - [ ] Feature
       - [ ] Doc
       - [ ] Refator
       - [ ] Others: 
   2. Does it affect the original behavior: 
       - [ ] Yes
       - [x] No
       - [ ] I don't know
   3. Has unit tests been added:
       - [x] Yes
       - [ ] No
       - [ ] No Need
   4. Has document been added or modified:
       - [ ] Yes
       - [ ] No
       - [x] No Need
   5. Does it need to update dependencies:
       - [ ] Yes
       - [x] No
   6. Are there any changes that cannot be rolled back:
       - [ ] Yes
       - [x] No
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] luozenglin commented on a diff in pull request #11316: [fix] Fix the query result error caused by the grouping sets statemen…

Posted by GitBox <gi...@apache.org>.
luozenglin commented on code in PR #11316:
URL: https://github.com/apache/doris/pull/11316#discussion_r933206295


##########
be/src/exec/repeat_node.h:
##########
@@ -52,12 +55,17 @@ class RepeatNode : public ExecNode {
     std::vector<std::vector<int64_t>> _grouping_list;
     // Tuple id used for output, it has new slots.
     TupleId _output_tuple_id;
-    const TupleDescriptor* _tuple_desc;
+    const TupleDescriptor* _output_tuple_desc;
 
     std::unique_ptr<RowBatch> _child_row_batch;
     bool _child_eos;
     int _repeat_id_idx;
     RuntimeState* _runtime_state;
+
+    // Exprs used to evaluate input rows
+    std::vector<Expr*> _probe_exprs;

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] github-actions[bot] commented on pull request #11316: [fix] Fix the query result error caused by the grouping sets statemen…

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #11316:
URL: https://github.com/apache/doris/pull/11316#issuecomment-1200706529

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] yangzhg commented on a diff in pull request #11316: [fix] Fix the query result error caused by the grouping sets statemen…

Posted by GitBox <gi...@apache.org>.
yangzhg commented on code in PR #11316:
URL: https://github.com/apache/doris/pull/11316#discussion_r932811407


##########
be/src/exec/repeat_node.h:
##########
@@ -52,12 +55,17 @@ class RepeatNode : public ExecNode {
     std::vector<std::vector<int64_t>> _grouping_list;
     // Tuple id used for output, it has new slots.
     TupleId _output_tuple_id;
-    const TupleDescriptor* _tuple_desc;
+    const TupleDescriptor* _output_tuple_desc;
 
     std::unique_ptr<RowBatch> _child_row_batch;
     bool _child_eos;
     int _repeat_id_idx;
     RuntimeState* _runtime_state;
+
+    // Exprs used to evaluate input rows
+    std::vector<Expr*> _probe_exprs;

Review Comment:
   why called `_probe_exprs` ？ there is no probe ops, you should remove probe



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] github-actions[bot] commented on pull request #11316: [fix] Fix the query result error caused by the grouping sets statemen…

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #11316:
URL: https://github.com/apache/doris/pull/11316#issuecomment-1200706544

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] yangzhg merged pull request #11316: [fix] Fix the query result error caused by the grouping sets statemen…

Posted by GitBox <gi...@apache.org>.
yangzhg merged PR #11316:
URL: https://github.com/apache/doris/pull/11316


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org