[jira] [Commented] (LIBCLOUD-618) Openstack create_volume should return StorageVolume

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LIBCLOUD-618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14147517#comment-14147517 ] 

ASF GitHub Bot commented on LIBCLOUD-618:
-----------------------------------------

GitHub user gertjanol opened a pull request:

    https://github.com/apache/libcloud/pull/365

    [LIBCLOUD-618] Make openstack create_volume return a StorageVolume

    The create_volume call in the OpenStack driver returns a bool to signify whether the call succeeded. This call should return a StorageVolume object, as other drivers already do (ec2, cloudstack, gce, etc).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ByteInternet/libcloud 618-os-create_volume-returns-storagevolume

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/365.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #365
    
----
commit 2ec27bc61a5dcc916caaddd8012007500fb19620
Author: Gertjan Oude Lohuis <ge...@byte.nl>
Date:   2014-09-25T07:37:27Z

    Make openstack create_volume return a StorageVolume

----


> Openstack create_volume should return StorageVolume
> ---------------------------------------------------
>
>                 Key: LIBCLOUD-618
>                 URL: https://issues.apache.org/jira/browse/LIBCLOUD-618
>             Project: Libcloud
>          Issue Type: Bug
>          Components: Compute
>    Affects Versions: 0.13.3
>            Reporter: Gertjan Oude Lohuis
>
> The create_volume call in the OpenStack driver returns a bool to signify whether the call succeeded. This call should return a StorageVolume object, as do other drivers (ec2, cloudstack, gce, etc).
> The fix is trivial, I'll create a pull request. I choose priority Major, since this flaw makes the create_volume call next to unusable, because it is impossible to know which volume was created by the call (since name is not unique).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)