[GitHub] [dubbo-go] DMwangnima commented on a diff in pull request #2426: modify triple template

["DMwangnima (via GitHub)" <gi...@apache.org>]

DMwangnima commented on code in PR #2426:
URL: https://github.com/apache/dubbo-go/pull/2426#discussion_r1328876057


##########
protocol/triple/triple-tool/gen/generator/tripleTpl.go:
##########
@@ -369,8 +369,8 @@ type {{.ServiceName}}Handler interface {
 	{{end}}
 }
 
-func Provide{{.ServiceName}}Handler(pro *provider.Provider, hdlr {{.ServiceName}}Handler) error {
-	return pro.Provide(hdlr, &{{.ServiceName}}_ServiceInfo)
+func Register{{.ServiceName}}Handler(srv *server.Server, hdlr {{.ServiceName}}Handler) error {

Review Comment:
   This function receives server.ServiceOption as parameter.



##########
protocol/triple/triple-tool/gen/generator/tripleTpl_test.go:
##########
@@ -452,12 +452,12 @@ type GreetServiceHandler interface {
 	
 }
 
-func ProvideGreetServiceHandler(pro *provider.Provider, hdlr GreetServiceHandler) error {
-	return pro.Provide(hdlr, &GreetService_ServiceInfo)
+func RegisterGreetServiceHandler(srv *server.Server, hdlr GreetServiceHandler) error {

Review Comment:
   Ditto.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org