You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2007/05/31 12:38:22 UTC
[Bug 5488] New: FH_HOST_EQ_D_D_D_D tests causing increase in FPs
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5488
Summary: FH_HOST_EQ_D_D_D_D tests causing increase in FPs
Product: Spamassassin
Version: 3.2.0
Platform: All
OS/Version: All
Status: NEW
Severity: normal
Priority: P5
Component: Rules
AssignedTo: dev@spamassassin.apache.org
ReportedBy: jhaar@trimble.co.nz
We are getting heaps of false positives off these rules - ironically
mainly from our IT services dealers/sellers/etc.
Since upgrading from SA-3.1* to 3.2.0, we have discovered that it
appears most small New Zealand businesses run mail servers on DSL links
with PTR records of the format "NN-NN-NN-NN.isp.carrier.nz". Hence they
end up with 2.2 points
(FH_HOST_EQ_D_D_D_D,FH_HOST_EQ_D_D_D_DB,RDNS_DYNAMIC) added without any
real effort. That plus their sputty HTML mails pushes them into the 5-7
range.
I know SA isn't really doing anything wrong, but it may imply the default
scores are too high? Justin Mason wondered if FH_HOST_EQ_D_D_D_D may be
overlapping the job of RDNS_DYNAMIC
BTW I have lowered the score of FH_HOST_EQ_D_D_D_D to 0.5 on our systems to
compensate.
Thanks!
Jason
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5488] FH_HOST_EQ_D_D_D_D tests causing increase in FPs
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5488
------- Additional Comments From jm@jmason.org 2007-05-31 04:06 -------
as I noted by mail:
'Well, FH_HOST_EQ_D_D_D_D is the main issue I'd say, since it has the
higher FPs and a much more significant score:
score FH_HOST_EQ_D_D_D_D 2.599 1.992 1.692 1.212 # n=2
score FH_HOST_EQ_D_D_D_DB 0.102 0.095 0.055 0.223 # n=2
STATISTICS-set3.txt: 7.010 10.9120 0.1316 0.988 0.64 0.22
FH_HOST_EQ_D_D_D_DB
STATISTICS-set3.txt: 20.447 31.7873 0.4565 0.986 0.58 1.21
FH_HOST_EQ_D_D_D_D
Since they overlap heavily with RDNS_DYNAMIC, perhaps we should consider
reducing/zeroing one or both scores for 3.2.1.'
I'd be in favour of zeroing both rules if the overlap figures are high.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5488] [review] FH_HOST_EQ_D_D_D_D tests causing increase in FPs
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5488
------- Additional Comments From jm@jmason.org 2007-06-07 11:43 -------
in trunk:
: jm 37...; svn commit -m "bug 5488: fix the 2 meta rules that also depended on
FH_HOST_EQ_D_D_D_DB: FM_DDDD_TIMES_2 and FM_SEX_HOSTDDDD. zeroed scores"
rules/50_scores.cf
Sending rules/50_scores.cf
Transmitting file data .
Committed revision 545264.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5488] [review] FH_HOST_EQ_D_D_D_D tests causing increase in FPs
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5488
sidney@sidney.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status Whiteboard|needs 2 votes |needs 1 votes
------- Additional Comments From sidney@sidney.com 2007-06-06 14:42 -------
Committed to trunk revision 544969. (Let's not forget to commit branch changes
to trunk, right? :-)
+1 for 3.2 branch
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5488] [review] FH_HOST_EQ_D_D_D_D tests causing increase in FPs
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5488
sidney@sidney.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
------- Additional Comments From sidney@sidney.com 2007-06-07 13:01 -------
Committed to branch 3.2 revision 545288.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5488] [review] FH_HOST_EQ_D_D_D_D tests causing increase in FPs
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5488
sidney@sidney.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status Whiteboard|needs 1 votes |needs a patch and 3 votes
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5488] FH_HOST_EQ_D_D_D_D tests causing increase in FPs
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5488
------- Additional Comments From spamassassin@dostech.ca 2007-06-02 01:52 -------
Created an attachment (id=3963)
--> (http://issues.apache.org/SpamAssassin/attachment.cgi?id=3963&action=view)
suggested patch
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5488] [review] FH_HOST_EQ_D_D_D_D tests causing increase in FPs
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5488
------- Additional Comments From sidney@sidney.com 2007-06-07 11:57 -------
+1
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5488] [review] FH_HOST_EQ_D_D_D_D tests causing increase in FPs
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5488
------- Additional Comments From jm@jmason.org 2007-06-07 01:33 -------
yeah, I think I may rename meta.t to run first, alongside basic_lint.t... I did
the same thing :(
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5488] [review] FH_HOST_EQ_D_D_D_D tests causing increase in FPs
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5488
------- Additional Comments From jm@jmason.org 2007-06-07 11:28 -------
Created an attachment (id=3976)
--> (http://issues.apache.org/SpamAssassin/attachment.cgi?id=3976&action=view)
fix r2
ok, this fixes that bug; it also zeroes the 2 meta rules that included
references to FH_HOST_EQ_D_D_D_DB: FM_DDDD_TIMES_2 and FM_SEX_HOSTDDDD.
those 2 rules had scores of 0 assigned by the perceptron, so we're
not losing anything...
here's a redone patch (which passes 'make test' this time ;)
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5488] FH_HOST_EQ_D_D_D_D tests causing increase in FPs
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5488
spamassassin@dostech.ca changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #3963 is|0 |1
obsolete| |
------- Additional Comments From spamassassin@dostech.ca 2007-06-02 01:58 -------
(From update of attachment 3963)
Attachment #3963 was meant for bug 5487.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5488] [review] FH_HOST_EQ_D_D_D_D tests causing increase in FPs
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5488
------- Additional Comments From sidney@sidney.com 2007-06-06 16:33 -------
Ackkk... What a time to decide to kill make test after I think that it has run
everything relevant to the particular patch! Sorry :-(
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5488] [review] FH_HOST_EQ_D_D_D_D tests causing increase in FPs
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5488
------- Additional Comments From jm@jmason.org 2007-06-06 16:22 -------
oops:
t/meta......................FM_SEX_HOSTDDDD depends on FH_HOST_EQ_D_D_D_D with 0
score in set 0
FM_DDDD_TIMES_2 depends on FH_HOST_EQ_D_D_D_D with 0 score in set 0
FM_SEX_HOSTDDDD depends on FH_HOST_EQ_D_D_D_D with 0 score in set 1
FM_DDDD_TIMES_2 depends on FH_HOST_EQ_D_D_D_D with 0 score in set 1
FM_SEX_HOSTDDDD depends on FH_HOST_EQ_D_D_D_D with 0 score in set 2
FM_DDDD_TIMES_2 depends on FH_HOST_EQ_D_D_D_D with 0 score in set 2
FM_SEX_HOSTDDDD depends on FH_HOST_EQ_D_D_D_D with 0 score in set 3
FM_DDDD_TIMES_2 depends on FH_HOST_EQ_D_D_D_D with 0 score in set 3
# Failed test 1 in t/meta.t at line 90
FAILED test 1
Failed 1/2 tests, 50.00% okay
looks like my attempt at the patch needs more work... -1
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5488] [review] FH_HOST_EQ_D_D_D_D tests causing increase in FPs
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5488
sidney@sidney.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #3972 is|0 |1
obsolete| |
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5488] [review] FH_HOST_EQ_D_D_D_D tests causing increase in FPs
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5488
sidney@sidney.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|FH_HOST_EQ_D_D_D_D tests |[review] FH_HOST_EQ_D_D_D_D
|causing increase in FPs |tests causing increase in
| |FPs
Status Whiteboard| |needs 3 votes?
------- Additional Comments From sidney@sidney.com 2007-06-04 21:46 -------
Should we go ahead and zero the rules and close this bug for 3.2.1? Does that
need votes? I'm setting the summary to [review] to flag this.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5488] [review] FH_HOST_EQ_D_D_D_D tests causing increase in FPs
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5488
spamassassin@dostech.ca changed:
What |Removed |Added
----------------------------------------------------------------------------
Status Whiteboard|needs 1 vote |go
------- Additional Comments From spamassassin@dostech.ca 2007-06-07 12:28 -------
+1
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5488] [review] FH_HOST_EQ_D_D_D_D tests causing increase in FPs
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5488
------- Additional Comments From jm@jmason.org 2007-06-06 13:56 -------
Created an attachment (id=3972)
--> (http://issues.apache.org/SpamAssassin/attachment.cgi?id=3972&action=view)
fix
yeah, it does need a patch, and votes; here it is.
my vote: +1 ;)
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5488] [review] FH_HOST_EQ_D_D_D_D tests causing increase in FPs
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5488
jm@jmason.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status Whiteboard|needs a patch and 3 votes |needs 2 votes
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5488] [review] FH_HOST_EQ_D_D_D_D tests causing increase in FPs
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5488
sidney@sidney.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status Whiteboard|needs 2 votes |needs 1 vote
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5488] [review] FH_HOST_EQ_D_D_D_D tests causing increase in FPs
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5488
jm@jmason.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status Whiteboard|needs 3 votes? |needs 2 votes
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5488] FH_HOST_EQ_D_D_D_D tests causing increase in FPs
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5488
spamassassin@dostech.ca changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|Undefined |3.2.1
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.