You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@syncope.apache.org by re...@apache.org on 2012/05/04 16:02:04 UTC
svn commit: r1333968 - in /incubator/syncope/trunk:
console/src/main/java/org/apache/syncope/console/SyncopeSession.java
core/src/main/java/org/apache/syncope/core/scheduling/SpringBeanJobFactory.java
Author: rene
Date: Fri May 4 14:02:03 2012
New Revision: 1333968
URL: http://svn.apache.org/viewvc?rev=1333968&view=rev
Log:
sonar: create defensive copies to prevent unpredicted changes
Modified:
incubator/syncope/trunk/console/src/main/java/org/apache/syncope/console/SyncopeSession.java
incubator/syncope/trunk/core/src/main/java/org/apache/syncope/core/scheduling/SpringBeanJobFactory.java
Modified: incubator/syncope/trunk/console/src/main/java/org/apache/syncope/console/SyncopeSession.java
URL: http://svn.apache.org/viewvc/incubator/syncope/trunk/console/src/main/java/org/apache/syncope/console/SyncopeSession.java?rev=1333968&r1=1333967&r2=1333968&view=diff
==============================================================================
--- incubator/syncope/trunk/console/src/main/java/org/apache/syncope/console/SyncopeSession.java (original)
+++ incubator/syncope/trunk/console/src/main/java/org/apache/syncope/console/SyncopeSession.java Fri May 4 14:02:03 2012
@@ -63,7 +63,8 @@ public class SyncopeSession extends WebS
}
public void setEntitlements(final String[] entitlements) {
- roles = new Roles(entitlements);
+ String[] defensiveCopy = entitlements.clone();
+ roles = new Roles(defensiveCopy);
}
public Roles getEntitlements() {
Modified: incubator/syncope/trunk/core/src/main/java/org/apache/syncope/core/scheduling/SpringBeanJobFactory.java
URL: http://svn.apache.org/viewvc/incubator/syncope/trunk/core/src/main/java/org/apache/syncope/core/scheduling/SpringBeanJobFactory.java?rev=1333968&r1=1333967&r2=1333968&view=diff
==============================================================================
--- incubator/syncope/trunk/core/src/main/java/org/apache/syncope/core/scheduling/SpringBeanJobFactory.java (original)
+++ incubator/syncope/trunk/core/src/main/java/org/apache/syncope/core/scheduling/SpringBeanJobFactory.java Fri May 4 14:02:03 2012
@@ -39,9 +39,9 @@ public class SpringBeanJobFactory extend
@Override
public void setIgnoredUnknownProperties(final String[] ignoredUnknownProperties) {
-
- super.setIgnoredUnknownProperties(ignoredUnknownProperties);
- this.ignoredUnknownProperties = ignoredUnknownProperties;
+ String[] defensiveCopy = ignoredUnknownProperties.clone();
+ super.setIgnoredUnknownProperties(defensiveCopy);
+ this.ignoredUnknownProperties = defensiveCopy;
}
@Override