You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by Fangmin Lv <lv...@gmail.com> on 2012/11/22 17:13:01 UTC
Review Request: Provide an improved GC algorithm

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8188/
-----------------------------------------------------------

Review request for bookkeeper.


Description
-------

r1 is the same as the code on review page https://reviews.apache.org/r/8141/, r2 is the whole change include BOOKKEEPER-463 and BOOKKEEPER-464, since change here is based on 8141, so I upload the based diff to simplify the comparison.

Main changes:
1. Add improved gc implementer with polling gc
2. Add garbage collector mode to configurate, and also add it to LAYOUT
3. Add compat test case


This addresses bug BOOKKEEPER-464.
    https://issues.apache.org/jira/browse/BOOKKEEPER-464


Diffs
-----

  bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Bookie.java 929be51 
  bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollector.java PRE-CREATION 
  bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/GarbageCollectorThread.java cecb74a 
  bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/ImprovedGarbageCollector.java PRE-CREATION 
  bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/InterleavedLedgerStorage.java c3f5149 
  bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/LedgerCacheImpl.java c8d2b21 
  bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/PollingGarbageCollector.java PRE-CREATION 
  bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/ScanAndCompareGarbageCollector.java PRE-CREATION 
  bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BKException.java e6a3807 
  bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeper.java 68a6fca 
  bookkeeper-server/src/main/java/org/apache/bookkeeper/client/BookKeeperAdmin.java 21e55a4 
  bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerDeleteOp.java eae1f37 
  bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerMetadata.java f6a817b 
  bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/AbstractConfiguration.java 2692fde 
  bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/AbstractZkLedgerManager.java 9dcb1b9 
  bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/ActiveLedgerManager.java 542b498 
  bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/FlatLedgerManager.java e284776 
  bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/FlatLedgerManagerFactory.java 329e0a7 
  bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/HierarchicalLedgerManager.java 3499a05 
  bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/HierarchicalLedgerManagerFactory.java c86b884 
  bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LedgerLayout.java 9a35218 
  bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LedgerManager.java 30e2b83 
  bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/LedgerManagerFactory.java a7fc247 
  bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/SnapshotMap.java c222f05 
  bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/DataFormats.java 38dcf86 
  bookkeeper-server/src/main/java/org/apache/bookkeeper/util/StringUtils.java 575e480 
  bookkeeper-server/src/main/java/org/apache/bookkeeper/util/ZkUtils.java 4073450 
  bookkeeper-server/src/main/proto/DataFormats.proto fd76fad 
  bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/CompactionTest.java 8ba9963 
  bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/LedgerCacheTest.java a24b1e2 
  bookkeeper-server/src/test/java/org/apache/bookkeeper/client/TestLedgerChecker.java d9dfdd0 
  bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/GcLedgersTest.java 7ecf937 
  bookkeeper-server/src/test/java/org/apache/bookkeeper/meta/LedgerManagerTestCase.java cd0b91f 
  bookkeeper-server/src/test/java/org/apache/bookkeeper/replication/AuditorLedgerCheckerTest.java 9f3f201 
  bookkeeper-server/src/test/java/org/apache/bookkeeper/replication/BookieLedgerIndexTest.java ead3494 
  bookkeeper-server/src/test/java/org/apache/bookkeeper/replication/TestReplicationWorker.java fdefebf 
  bookkeeper-server/src/test/java/org/apache/bookkeeper/test/BookieJournalRollingTest.java d1c4b33 
  bookkeeper-server/src/test/java/org/apache/bookkeeper/test/LedgerDeleteTest.java 6abd566 
  bookkeeper-server/src/test/java/org/apache/bookkeeper/test/MultiLedgerManagerTestCase.java dd3450c 
  bookkeeper-server/src/test/java/org/apache/bookkeeper/test/TestBackwardCompat.java 5502df7 
  bookkeeper-server/src/test/java/org/apache/bookkeeper/test/ZooKeeperUtil.java 238f77f 
  bookkeeper-server/src/test/java/org/apache/bookkeeper/util/TestUtils.java PRE-CREATION 

Diff: https://reviews.apache.org/r/8188/diff/


Testing
-------


Thanks,

Fangmin Lv