You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Damodar Reddy Talakanti <da...@citrix.com> on 2014/12/04 07:20:38 UTC
Review Request 28691: Cloudstack records ids into events table
instead of UUIDs for create snapshot command
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28691/
-----------------------------------------------------------
Review request for cloudstack and Kishan Kavala.
Repository: cloudstack-git
Description
-------
Currently when create a snaphost it logs 3 events(scheduled, started, completed) into event table. Out of these 3 "started" and "completed" events has IDs in the descripton insted of UUIDs in event tbale.
Diffs
-----
api/src/org/apache/cloudstack/api/command/user/snapshot/CreateSnapshotCmd.java df7fe82
Diff: https://reviews.apache.org/r/28691/diff/
Testing
-------
Thanks,
Damodar Reddy Talakanti
Re: Review Request 28691: Cloudstack records ids into events table
instead of UUIDs for create snapshot command
Posted by Sebastien Goasguen <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28691/#review79005
-----------------------------------------------------------
Thank you for submitting your CloudStack contribution through review board. After discussion on the dev@cloudstack.apache.org the community decided to close down review board and start accepting contributiong through GitHub pull requests. We have been using GH PR for several months now and the process is better than review board.
We will keep Review Board open for another week to give you time to migrate your patch to a github PR if you wish. After that time, your patch will no longer be viewable (even though it will not be deleted).
Please consider submitting a pull request.
Great instructions are available at:
https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md
Thank you very much for your time and your contribution to Apache CloudStack, we hope that using this new process will encourage you to do more.
- Sebastien Goasguen
On Dec. 4, 2014, 10:08 a.m., Damodar Reddy Talakanti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28691/
> -----------------------------------------------------------
>
> (Updated Dec. 4, 2014, 10:08 a.m.)
>
>
> Review request for cloudstack and Kishan Kavala.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Currently when create a snaphost it logs 3 events(scheduled, started, completed) into event table. Out of these 3 "started" and "completed" events has IDs in the descripton insted of UUIDs in event tbale.
>
>
> Diffs
> -----
>
> api/src/org/apache/cloudstack/api/command/user/snapshot/CreateSnapshotCmd.java df7fe82
>
> Diff: https://reviews.apache.org/r/28691/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Damodar Reddy Talakanti
>
>
Re: Review Request 28691: Cloudstack records ids into events table
instead of UUIDs for create snapshot command
Posted by Damodar Reddy Talakanti <da...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28691/
-----------------------------------------------------------
(Updated Dec. 4, 2014, 10:08 a.m.)
Review request for cloudstack and Kishan Kavala.
Changes
-------
updated patch with missed changes
Repository: cloudstack-git
Description
-------
Currently when create a snaphost it logs 3 events(scheduled, started, completed) into event table. Out of these 3 "started" and "completed" events has IDs in the descripton insted of UUIDs in event tbale.
Diffs (updated)
-----
api/src/org/apache/cloudstack/api/command/user/snapshot/CreateSnapshotCmd.java df7fe82
Diff: https://reviews.apache.org/r/28691/diff/
Testing
-------
Thanks,
Damodar Reddy Talakanti