You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/12/15 02:30:27 UTC
[GitHub] [camel-website] djencks opened a new pull request #721: See #720: POC Main local builds
djencks opened a new pull request #721:
URL: https://github.com/apache/camel-website/pull/721
camel-website changes for local builds POC.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-website] djencks commented on a change in pull request #721: See #720: POC Main local builds
Posted by GitBox <gi...@apache.org>.
djencks commented on a change in pull request #721:
URL: https://github.com/apache/camel-website/pull/721#discussion_r769763760
##########
File path: package.json
##########
@@ -50,7 +57,7 @@
"toml": "~3.0"
},
"workspaces": [
- "antora-ui-camel"
- ],
- "packageManager": "yarn@3.1.0"
Review comment:
Yarn removed it when I updated dependencies, I'm not sure why. Perhaps because I followed recent instructions for node >= 16.10 and ran `corepack enable`? https://yarnpkg.com/getting-started/install
I recently updated several of my projects to use yarn pnp and some got the packageManager key and some didn't.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-website] djencks commented on a change in pull request #721: See #720: POC Main local builds
Posted by GitBox <gi...@apache.org>.
djencks commented on a change in pull request #721:
URL: https://github.com/apache/camel-website/pull/721#discussion_r769764443
##########
File path: package.json
##########
@@ -24,17 +24,24 @@
"preview": "run-s preview:antora preview:hugo",
"preview:antora": "antora --clean --fetch antora-playbook.yml",
"preview:hugo": "hugo server -D",
- "preview:netlify": "netlify deploy --dir public"
+ "preview:netlify": "netlify deploy --dir public",
+ "build-full": "antora local-antora-playbook-full.yml --stacktrace",
+ "build-partial": "antora local-antora-playbook-partial.yml --stacktrace"
Review comment:
I think the longer name with local will be better, otherwise antora:build and antora:build-full will be too confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-website] djencks commented on pull request #721: See #720: POC Main local builds
Posted by GitBox <gi...@apache.org>.
djencks commented on pull request #721:
URL: https://github.com/apache/camel-website/pull/721#issuecomment-994931457
> Not sure where the new `util` project is used. Is `util/jsonpath-util.js` missing from the PR?
util/jsonpath-util.js has been there for a long time: this makes it available as a package. The camel-kamelets PR has a kamelets.js that requires it. However for consistency, I should change the `requires@` attribute to use the package rather than the path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-website] github-actions[bot] commented on pull request #721: See #720: POC Main local builds
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #721:
URL: https://github.com/apache/camel-website/pull/721#issuecomment-994260376
🚀 Preview is available at https://pr-721--camel.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-website] github-actions[bot] commented on pull request #721: See #720: POC Main local builds
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #721:
URL: https://github.com/apache/camel-website/pull/721#issuecomment-995290768
🚀 Preview is available at https://pr-721--camel.netlify.app
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-website] zregvart commented on pull request #721: See #720: POC Main local builds
Posted by GitBox <gi...@apache.org>.
zregvart commented on pull request #721:
URL: https://github.com/apache/camel-website/pull/721#issuecomment-994994607
I'll carve out some time to test his on my end, it seems like a good thing and implementation/user experience looks simple. A good start to having incremental builds on CI as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-website] djencks merged pull request #721: See #720: POC Main local builds
Posted by GitBox <gi...@apache.org>.
djencks merged pull request #721:
URL: https://github.com/apache/camel-website/pull/721
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-website] zregvart commented on a change in pull request #721: See #720: POC Main local builds
Posted by GitBox <gi...@apache.org>.
zregvart commented on a change in pull request #721:
URL: https://github.com/apache/camel-website/pull/721#discussion_r769348006
##########
File path: package.json
##########
@@ -50,7 +57,7 @@
"toml": "~3.0"
},
"workspaces": [
- "antora-ui-camel"
- ],
- "packageManager": "yarn@3.1.0"
Review comment:
Accidentally removed?
##########
File path: package.json
##########
@@ -24,17 +24,24 @@
"preview": "run-s preview:antora preview:hugo",
"preview:antora": "antora --clean --fetch antora-playbook.yml",
"preview:hugo": "hugo server -D",
- "preview:netlify": "netlify deploy --dir public"
+ "preview:netlify": "netlify deploy --dir public",
+ "build-full": "antora local-antora-playbook-full.yml --stacktrace",
+ "build-partial": "antora local-antora-playbook-partial.yml --stacktrace"
Review comment:
(nit) This only builds Antora bits, so I'd call them something like `build:antora-full/partial`, adding in `local` into the mix would be beneficial but that would also make it quite long.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org