You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/15 12:23:49 UTC
[GitHub] [spark] kyoty opened a new pull request #32189: [SPARK-34787] Option variable in Spark historyServer log should be displayed as actual value instead of Some(XX)
kyoty opened a new pull request #32189:
URL: https://github.com/apache/spark/pull/32189
What changes were proposed in this pull request?
Make the attemptId in the log of historyServer to be more easily to read.
Why are the changes needed?
Option variable in Spark historyServer log should be displayed as actual value instead of Some(XX)
Does this PR introduce any user-facing change?
No
How was this patch tested?
manual test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on a change in pull request #32189: [SPARK-34787][CORE] Option variable in Spark historyServer log should be displayed as actual value instead of Some(XX)
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on a change in pull request #32189:
URL: https://github.com/apache/spark/pull/32189#discussion_r614534750
##########
File path: core/src/main/scala/org/apache/spark/deploy/history/ApplicationCache.scala
##########
@@ -156,18 +156,18 @@ private[history] class ApplicationCache(
*/
@throws[NoSuchElementException]
private def loadApplicationEntry(appId: String, attemptId: Option[String]): CacheEntry = {
- logDebug(s"Loading application Entry $appId/$attemptId")
+ logDebug(s"Loading application Entry $appId/${attemptId.mkString}")
Review comment:
Let's put `$appId/${attemptId.mkString}` to a lazy val
```
lazy val application = s"$appId/${attemptId.mkString}"
```
to reduce duplciate code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #32189: [SPARK-34787] Option variable in Spark historyServer log should be displayed as actual value instead of Some(XX)
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32189:
URL: https://github.com/apache/spark/pull/32189#issuecomment-820452229
Hm, did your fork enable Github Actions? The CI was lately changed so there is a bunch of holes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] kyoty commented on pull request #32189: [SPARK-34787] Option variable in Spark historyServer log should be displayed as actual value instead of Some(XX)
Posted by GitBox <gi...@apache.org>.
kyoty commented on pull request #32189:
URL: https://github.com/apache/spark/pull/32189#issuecomment-820505770
Sorry, I forget this... now it works fine, thanks for your great job!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #32189: [SPARK-34787] Option variable in Spark historyServer log should be displayed as actual value instead of Some(XX)
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #32189:
URL: https://github.com/apache/spark/pull/32189#issuecomment-820502438
**[Test build #752477839](https://github.com/kyoty/spark/actions/runs/752477839)** for PR 32189 at commit [`7bf371d`](https://github.com/kyoty/spark/commit/7bf371dad31307d2d06412f819646172d8fb5928).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #32189: [SPARK-34787][CORE] Option variable in Spark historyServer log should be displayed as actual value instead of Some(XX)
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #32189:
URL: https://github.com/apache/spark/pull/32189#issuecomment-821895622
Merged to master. Thank you, @kyoty and all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] kyoty commented on pull request #32189: [SPARK-34787] Option variable in Spark historyServer log should be displayed as actual value instead of Some(XX)
Posted by GitBox <gi...@apache.org>.
kyoty commented on pull request #32189:
URL: https://github.com/apache/spark/pull/32189#issuecomment-820383453
@HyukjinKwon I am sorry that I forked the branch of master again, but there is still an error. How should I deal with it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #32189: [SPARK-34787][CORE] Option variable in Spark historyServer log should be displayed as actual value instead of Some(XX)
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #32189:
URL: https://github.com/apache/spark/pull/32189#issuecomment-821058913
**[Test build #755174630](https://github.com/kyoty/spark/actions/runs/755174630)** for PR 32189 at commit [`3e11b6b`](https://github.com/kyoty/spark/commit/3e11b6b7daded02ecf67a95822ad2cdd313f56df).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] kyoty commented on pull request #32189: [SPARK-34787][CORE] Option variable in Spark historyServer log should be displayed as actual value instead of Some(XX)
Posted by GitBox <gi...@apache.org>.
kyoty commented on pull request #32189:
URL: https://github.com/apache/spark/pull/32189#issuecomment-821060261
cc @HyukjinKwon @gengliangwang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32189: [SPARK-34787] Option variable in Spark historyServer log should be displayed as actual value instead of Some(XX)
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32189:
URL: https://github.com/apache/spark/pull/32189#issuecomment-820391842
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #32189: [SPARK-34787][CORE] Option variable in Spark historyServer log should be displayed as actual value instead of Some(XX)
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #32189:
URL: https://github.com/apache/spark/pull/32189
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #32189: [SPARK-34787][CORE] Option variable in Spark historyServer log should be displayed as actual value instead of Some(XX)
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #32189:
URL: https://github.com/apache/spark/pull/32189#issuecomment-820848807
cc @Ngone51 too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #32189: [SPARK-34787] Option variable in Spark historyServer log should be displayed as actual value instead of Some(XX)
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #32189:
URL: https://github.com/apache/spark/pull/32189#issuecomment-820503921
**[Test build #752481418](https://github.com/kyoty/spark/actions/runs/752481418)** for PR 32189 at commit [`5cfcfda`](https://github.com/kyoty/spark/commit/5cfcfda5974e29fb5e9a427a29429f577a471b76).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org