[I] [Improvement][Service] The method refreshMasterList was executed one more time in function putAll. [dolphinscheduler]

["DaqianLiao (via GitHub)" <gi...@apache.org>]

DaqianLiao opened a new issue, #15962:
URL: https://github.com/apache/dolphinscheduler/issues/15962

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
   
   
   ### Description
   
   In the MasterPriorityQueue class, the refreshMasterList method is executed each time when a Server is added by put method. Therefore, there is no need to execute the refreshMasterList method again after iterating through the putAll method.
   
       public void put(Server serverInfo) {
           this.queue.put(serverInfo);
           refreshMasterList();
       }
   
      public void putAll(Collection<Server> serverList) {
           for (Server server : serverList) {
               this.queue.put(server);
           }
           refreshMasterList(); // should remove
       }
   
   ### Are you willing to submit a PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [Improvement][Service] The method refreshMasterList was executed one more time in function putAll. [dolphinscheduler]

["DaqianLiao (via GitHub)" <gi...@apache.org>]

DaqianLiao closed issue #15962: [Improvement][Service] The method refreshMasterList was executed one more time in function putAll.
URL: https://github.com/apache/dolphinscheduler/issues/15962


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org