You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/10/05 00:49:49 UTC

[GitHub] sijie commented on a change in pull request #2728: [function][runtime] NPE at RuntimeSpawner

sijie commented on a change in pull request #2728: [function][runtime] NPE at RuntimeSpawner
URL: https://github.com/apache/pulsar/pull/2728#discussion_r222867278
 
 

 ##########
 File path: pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/RuntimeSpawner.java
 ##########
 @@ -82,7 +83,8 @@ public void start() throws Exception {
             processLivenessCheckTimer.scheduleAtFixedRate(new TimerTask() {
                 @Override
                 public void run() {
-                    if (!runtime.isAlive()) {
+                    Runtime runtime = RuntimeSpawner.this.runtime;
 
 Review comment:
   if you close the runtime first and cancel the timer later. that's why I also changed the order of closing sequence.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services