You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2019/06/13 21:31:12 UTC
[kudu-CR](branch-1.10.x) [java] Add unit tests demonstrating good behavior of scan tokens when range partitions are dropped
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13643
Change subject: [java] Add unit tests demonstrating good behavior of scan tokens when range partitions are dropped
......................................................................
[java] Add unit tests demonstrating good behavior of scan tokens when range partitions are dropped
It turns out that scan tokens in the Java client behave nicely with
respect to dropping range partitions- one can drop a range partition
anytime after creating the tokens and the tokens can still be used.
There is a case where some tablets in the dropped partition will still
return rows, while others don't, but that can be looked at as a
manifestation of the fact that tablet alters aren't linearizable in Kudu
(yet?).
Change-Id: Ib25ea2b62321934313c9c8852f0bc00b28bf7f2b
Reviewed-on: http://gerrit.cloudera.org:8080/13565
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Kudu Jenkins
(cherry picked from commit c4308869580c6cb8b57a809395883a0b2614f883)
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestScanToken.java
1 file changed, 67 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/43/13643/1
--
To view, visit http://gerrit.cloudera.org:8080/13643
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.10.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib25ea2b62321934313c9c8852f0bc00b28bf7f2b
Gerrit-Change-Number: 13643
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR](branch-1.10.x) [java] Add unit tests demonstrating good behavior of scan tokens when range partitions are dropped
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13643 )
Change subject: [java] Add unit tests demonstrating good behavior of scan tokens when range partitions are dropped
......................................................................
[java] Add unit tests demonstrating good behavior of scan tokens when range partitions are dropped
It turns out that scan tokens in the Java client behave nicely with
respect to dropping range partitions- one can drop a range partition
anytime after creating the tokens and the tokens can still be used.
There is a case where some tablets in the dropped partition will still
return rows, while others don't, but that can be looked at as a
manifestation of the fact that tablet alters aren't linearizable in Kudu
(yet?).
Change-Id: Ib25ea2b62321934313c9c8852f0bc00b28bf7f2b
Reviewed-on: http://gerrit.cloudera.org:8080/13565
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Kudu Jenkins
(cherry picked from commit c4308869580c6cb8b57a809395883a0b2614f883)
Reviewed-on: http://gerrit.cloudera.org:8080/13643
Reviewed-by: Will Berkeley <wd...@gmail.com>
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestScanToken.java
1 file changed, 67 insertions(+), 1 deletion(-)
Approvals:
Will Berkeley: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/13643
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.10.x
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib25ea2b62321934313c9c8852f0bc00b28bf7f2b
Gerrit-Change-Number: 13643
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR](branch-1.10.x) [java] Add unit tests demonstrating good behavior of scan tokens when range partitions are dropped
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/13643 )
Change subject: [java] Add unit tests demonstrating good behavior of scan tokens when range partitions are dropped
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13643
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.10.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib25ea2b62321934313c9c8852f0bc00b28bf7f2b
Gerrit-Change-Number: 13643
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Fri, 14 Jun 2019 16:43:49 +0000
Gerrit-HasComments: No