You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by Jacques Le Roux <ja...@les7arts.com> on 2010/07/30 09:11:42 UTC
Re: svn commit: r980657 - /ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/otherops/Log.java
Thanks Adrian!
Jacques
From: <ad...@apache.org>
> Author: adrianc
> Date: Fri Jul 30 06:26:35 2010
> New Revision: 980657
>
> URL: http://svn.apache.org/viewvc?rev=980657&view=rev
> Log:
> Log element in simple method now prints source file line number.
>
> Modified:
> ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/otherops/Log.java
>
> Modified: ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/otherops/Log.java
> URL:
> http://svn.apache.org/viewvc/ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/otherops/Log.java?rev=980657&r1=980656&r2=980657&view=diff
> ==============================================================================
> --- ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/otherops/Log.java (original)
> +++ ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/otherops/Log.java Fri Jul 30 06:26:35 2010
> @@ -44,12 +44,14 @@ public class Log extends MethodOperation
>
> String levelStr;
> String message;
> + Object startLine;
> List<MethodString> methodStrings = null;
>
> public Log(Element element, SimpleMethod simpleMethod) {
> super(element, simpleMethod);
> this.message = element.getAttribute("message");
> this.levelStr = element.getAttribute("level");
> + this.startLine = element.getUserData("startLine");
>
> List<? extends Element> methodStringElements = UtilXml.childElementList(element);
> if (methodStringElements.size() > 0) {
> @@ -97,6 +99,10 @@ public class Log extends MethodOperation
> buf.append(methodLocation);
> buf.append("#");
> buf.append(this.simpleMethod.getMethodName());
> + if (this.startLine != null) {
> + buf.append(" line ");
> + buf.append(this.startLine);
> + }
> buf.append("] ");
>
> if (message != null) buf.append(message);
>
>
Re: svn commit: r980657 - /ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/otherops/Log.java
Posted by Jacques Le Roux <ja...@les7arts.com>.
So thank you Adam (and not only for that!)
Jacques
From: "Adrian Crum" <ad...@yahoo.com>
> Thank Adam - he did all the hard work. I just exposed the line numbers he tucked away a while ago.
>
> -Adrian
>
> --- On Fri, 7/30/10, Jacques Le Roux <ja...@les7arts.com> wrote:
>
>> From: Jacques Le Roux <ja...@les7arts.com>
>> Subject: Re: svn commit: r980657 - /ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/otherops/Log.java
>> To: dev@ofbiz.apache.org
>> Date: Friday, July 30, 2010, 12:11 AM
>> Thanks Adrian!
>>
>> Jacques
>>
>> From: <ad...@apache.org>
>> > Author: adrianc
>> > Date: Fri Jul 30 06:26:35 2010
>> > New Revision: 980657
>> >
>> > URL: http://svn.apache.org/viewvc?rev=980657&view=rev
>> > Log:
>> > Log element in simple method now prints source file
>> line number.
>> >
>> > Modified:
>> >
>> ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/otherops/Log.java
>> >
>> > Modified:
>> ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/otherops/Log.java
>> > URL:
>> > http://svn.apache.org/viewvc/ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/otherops/Log.java?rev=980657&r1=980656&r2=980657&view=diff
>> >
>> ==============================================================================
>> > ---
>> ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/otherops/Log.java
>> (original)
>> > +++
>> ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/otherops/Log.java
>> Fri Jul 30 06:26:35 2010
>> > @@ -44,12 +44,14 @@ public class Log extends
>> MethodOperation
>> >
>> > String levelStr;
>> > String message;
>> > + Object startLine;
>> > List<MethodString>
>> methodStrings = null;
>> >
>> > public Log(Element element,
>> SimpleMethod simpleMethod) {
>> > super(element,
>> simpleMethod);
>> > this.message =
>> element.getAttribute("message");
>> > this.levelStr =
>> element.getAttribute("level");
>> > + this.startLine =
>> element.getUserData("startLine");
>> >
>> > List<?
>> extends Element> methodStringElements =
>> UtilXml.childElementList(element);
>> > if
>> (methodStringElements.size() > 0) {
>> > @@ -97,6 +99,10 @@ public class Log extends
>> MethodOperation
>> >
>> buf.append(methodLocation);
>> >
>> buf.append("#");
>> >
>> buf.append(this.simpleMethod.getMethodName());
>> > + if (this.startLine !=
>> null) {
>> > +
>> buf.append(" line ");
>> > +
>> buf.append(this.startLine);
>> > + }
>> > buf.append("]
>> ");
>> >
>> > if (message !=
>> null) buf.append(message);
>> >
>> >
>>
>>
>>
>
>
>
>
Re: svn commit: r980657 - /ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/otherops/Log.java
Posted by Adrian Crum <ad...@yahoo.com>.
Thank Adam - he did all the hard work. I just exposed the line numbers he tucked away a while ago.
-Adrian
--- On Fri, 7/30/10, Jacques Le Roux <ja...@les7arts.com> wrote:
> From: Jacques Le Roux <ja...@les7arts.com>
> Subject: Re: svn commit: r980657 - /ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/otherops/Log.java
> To: dev@ofbiz.apache.org
> Date: Friday, July 30, 2010, 12:11 AM
> Thanks Adrian!
>
> Jacques
>
> From: <ad...@apache.org>
> > Author: adrianc
> > Date: Fri Jul 30 06:26:35 2010
> > New Revision: 980657
> >
> > URL: http://svn.apache.org/viewvc?rev=980657&view=rev
> > Log:
> > Log element in simple method now prints source file
> line number.
> >
> > Modified:
> >
> ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/otherops/Log.java
> >
> > Modified:
> ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/otherops/Log.java
> > URL:
> > http://svn.apache.org/viewvc/ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/otherops/Log.java?rev=980657&r1=980656&r2=980657&view=diff
> >
> ==============================================================================
> > ---
> ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/otherops/Log.java
> (original)
> > +++
> ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/otherops/Log.java
> Fri Jul 30 06:26:35 2010
> > @@ -44,12 +44,14 @@ public class Log extends
> MethodOperation
> >
> > String levelStr;
> > String message;
> > + Object startLine;
> > List<MethodString>
> methodStrings = null;
> >
> > public Log(Element element,
> SimpleMethod simpleMethod) {
> > super(element,
> simpleMethod);
> > this.message =
> element.getAttribute("message");
> > this.levelStr =
> element.getAttribute("level");
> > + this.startLine =
> element.getUserData("startLine");
> >
> > List<?
> extends Element> methodStringElements =
> UtilXml.childElementList(element);
> > if
> (methodStringElements.size() > 0) {
> > @@ -97,6 +99,10 @@ public class Log extends
> MethodOperation
> >
> buf.append(methodLocation);
> >
> buf.append("#");
> >
> buf.append(this.simpleMethod.getMethodName());
> > + if (this.startLine !=
> null) {
> > +
> buf.append(" line ");
> > +
> buf.append(this.startLine);
> > + }
> > buf.append("]
> ");
> >
> > if (message !=
> null) buf.append(message);
> >
> >
>
>
>