You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/06/13 05:44:23 UTC

[GitHub] [airflow] mik-laj commented on pull request #9267: Add temp airflow remote manifest file to .gitignore

mik-laj commented on pull request #9267:
URL: https://github.com/apache/airflow/pull/9267#issuecomment-643574179


   Why don't we move this file to the temp directory?
   ````diff
   -    # Docker needs the file passed to --cidfile to not exist, so we can't use mktemp
   -    TMP_CONTAINER_ID="remote-airflow-manifest-$$.container_id"
   +    TMP_CONTAINER_DIR="$(mktemp -d)"
   +    TMP_CONTAINER_ID="$(TMP_CONTAINER_DIR)/remote-airflow-manifest-$$.container_id"
        FILES_TO_CLEANUP_ON_EXIT+=("$TMP_CONTAINER_DIR")
   
        TMP_MANIFEST_REMOTE_JSON=$(mktemp)
        TMP_MANIFEST_REMOTE_SHA=$(mktemp)
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org