You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sedona.apache.org by "iGN5117 (via GitHub)" <gi...@apache.org> on 2023/10/23 21:43:56 UTC
[PR] [DOCS] Update binder notebook examples [sedona]
iGN5117 opened a new pull request, #1056:
URL: https://github.com/apache/sedona/pull/1056
## Did you read the Contributor Guide?
- Yes, I have read [Contributor Rules](https://sedona.apache.org/latest-snapshot/community/rule/) and [Contributor Development Guide](https://sedona.apache.org/latest-snapshot/community/develop/)
## Is this PR related to a JIRA ticket?
- No, this is a documentation update. The PR name follows the format `[DOCS] my subject`.
## What changes were proposed in this PR?
- Update sedona and geotools version in binder notebook examples
- Updated visualization to use SedonaKepler
- Added tutorial for Uber H3 cell visualization.
## How was this patch tested?
- Ran notebooks
## Did this PR include necessary documentation updates?
- Yes, I have updated the documentation update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [DOCS] Update binder notebook examples [sedona]
Posted by "jiayuasu (via GitHub)" <gi...@apache.org>.
jiayuasu commented on code in PR #1056:
URL: https://github.com/apache/sedona/pull/1056#discussion_r1378284136
##########
python/Pipfile:
##########
Review Comment:
Please remove the change of this file as it is not related to the binder notebooks.
##########
examples/spark-viz/build.sbt:
##########
@@ -46,7 +46,7 @@ val ScalaCompatibleVersion = "2.12"
// Change the dependency scope to "provided" when you run "sbt assembly"
val dependencyScope = "compile"
-val geotoolsVersion = "1.4.0-28.2"
Review Comment:
Please remove the change of this file as it is not related to the binder notebooks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [DOCS] Update binder notebook examples [sedona]
Posted by "iGN5117 (via GitHub)" <gi...@apache.org>.
iGN5117 commented on code in PR #1056:
URL: https://github.com/apache/sedona/pull/1056#discussion_r1379215532
##########
binder/postBuild:
##########
@@ -1,6 +1,6 @@
#Download Apache Spark
-wget https://archive.apache.org/dist/spark/spark-3.3.2/spark-3.3.2-bin-hadoop3.tgz
-tar -xzf spark-3.3.2-bin-hadoop3.tgz
+wget https://archive.apache.org/dist/spark/spark-3.4.0/spark-3.4.0-bin-hadoop3.tgz
+tar -xzf spark-3.4.0-bin-hadoop3.tgz
Review Comment:
yes I removed this to test if this was causing any issues with the binder. Added them back
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [DOCS] Update binder notebook examples [sedona]
Posted by "jiayuasu (via GitHub)" <gi...@apache.org>.
jiayuasu commented on code in PR #1056:
URL: https://github.com/apache/sedona/pull/1056#discussion_r1378287485
##########
binder/postBuild:
##########
@@ -1,6 +1,6 @@
#Download Apache Spark
-wget https://archive.apache.org/dist/spark/spark-3.3.2/spark-3.3.2-bin-hadoop3.tgz
-tar -xzf spark-3.3.2-bin-hadoop3.tgz
+wget https://archive.apache.org/dist/spark/spark-3.4.0/spark-3.4.0-bin-hadoop3.tgz
+tar -xzf spark-3.4.0-bin-hadoop3.tgz
Review Comment:
Please add the following code
```
hadoop_s3_version=3.3.4
aws_sdk_version=1.12.402
curl https://repo1.maven.org/maven2/org/apache/hadoop/hadoop-aws/${hadoop_s3_version}/hadoop-aws-${hadoop_s3_version}.jar -o $HOME/spark-3.4.0-bin-hadoop3/jars/hadoop-aws-${hadoop_s3_version}.jar
curl https://repo1.maven.org/maven2/com/amazonaws/aws-java-sdk-bundle/${aws_sdk_version}/aws-java-sdk-bundle-${aws_sdk_version}.jar -o $HOME/spark-3.4.0-bin-hadoop3/jars/aws-java-sdk-bundle-${aws_sdk_version}.jar
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [DOCS] Update binder notebook examples [sedona]
Posted by "jiayuasu (via GitHub)" <gi...@apache.org>.
jiayuasu merged PR #1056:
URL: https://github.com/apache/sedona/pull/1056
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [DOCS] Update binder notebook examples [sedona]
Posted by "jiayuasu (via GitHub)" <gi...@apache.org>.
jiayuasu commented on code in PR #1056:
URL: https://github.com/apache/sedona/pull/1056#discussion_r1369425185
##########
python/Pipfile:
##########
@@ -14,7 +14,7 @@ pytest-cov = "*"
shapely="<=1.8.5"
pandas="<=1.3.5"
geopandas="<=0.10.2"
-pyspark=">=2.3.0"
+pyspark="*"
Review Comment:
Please change this to pyspark=">=3.0.0"
##########
examples/spark-viz/build.sbt:
##########
@@ -39,7 +39,7 @@ val SparkCompatibleVersion = "3.0"
val HadoopVersion = "2.7.2"
Review Comment:
SeondaViz package is no longer available. The correct dependency should be `sedona-spark-3.0`
##########
binder/ApacheSedonaRaster.ipynb:
##########
Review Comment:
This notebook does not work. It still uses old `geotiff` API that has been dropped. We should remove example for old MapAlgebra functions and use the whole new pipeline we design in 1.5.0
##########
binder/ApacheSedonaSQL.ipynb:
##########
Review Comment:
This notebook is not working in Binder
##########
binder/ApacheSedonaSQL_SpatialJoin_AirportsPerCountry.ipynb:
##########
Review Comment:
KeplerGL is not shown in all output.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org