You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/07/26 02:16:17 UTC

[GitHub] [kafka] chia7712 commented on pull request #11128: MINOR: remove partition-level error from MetadataResponse#errorCounts

chia7712 commented on pull request #11128:
URL: https://github.com/apache/kafka/pull/11128#issuecomment-886321557


   > Are there other similar cases in the original PR or is this the only one?
   
   `StopReplicResponse` (https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/common/requests/StopReplicaResponse.java#L55) has similar issue. will take a look at others.
   
   For another, I'm thinking about better code style. As server-side does not add partition error to response when top-level gets error, `errorCounts` should be fine to collect all error code from all elements. It seems to me the only challenge is that the count of `NONE` may get higher.
   
   Could you share the regression you mentioned to me if I overlook the real problem?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org