You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by Roberto Tyley <Ro...@reuters.com> on 2004/07/08 17:43:48 UTC

RE: Struts 1.2.1 release? - patches take-up


Given that the committers are busy people, I'd guess one way to get a patch considered is to actively seek out struts developers who are experiencing the problem that your patch fixes, and get them to test it for you - you're doing them a favour, and if several of them add a 'works for me' to the ticket, there's a better chance it'll get noticed by the commiters.

Would I be right in assuming your patch is the one on bug 29824 - that handles parameters that are not encoded in ISO-8859-1? That actually sounds like it /might/ solve a problem I recently had with struts - a form was turning the acute 'e' in 'café' into garbage, hmm! I'd been thinking I needed to change character encoding in tomcat or something, but I'll try applying your patch and see what happens.

Myself, I've got a teenie-tiny patch to add message parameter XML-escaping to <html:messages> (bug 26112) that isn't going anywhere - it hasn't received any feedback. Still, running a patch version of Struts does make one feel 'special' :-)


Roberto


-----Original Message-----
From: KUROSAKA Teruhiko [mailto:kuro@bhlab.com] 
Sent: 08 July 2004 15:58
To: Struts Developers List
Subject: Re: Struts 1.2.1 release?

As far as I can tell by monitoring this list, 1.2.1 seems to fix
only face related few bugs.  It didn't pick most patches available
in bugzilla.

Could you tell comitters pick patches for the next release? Only
by a chance?

I'm not complaining.  I just want to know what else I can do
to make sure my patch will be picked next time.

Regards,
-- 
KUROSAKA ("Kuro") Teruhiko, San Francisco, California, USA
Internationalization Consultant --- now available for new contracts!
http://www.bhlab.com/


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org



-----------------------------------------------------------------
        Visit our Internet site at http://www.reuters.com

Get closer to the financial markets with Reuters Messaging - for more
information and to register, visit http://www.reuters.com/messaging

Any views expressed in this message are those of  the  individual
sender,  except  where  the sender specifically states them to be
the views of Reuters Ltd.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


Re: Struts 1.2.1 release? - patches take-up

Posted by Ted Husted <hu...@apache.org>.
On Thu, 08 Jul 2004 09:42:53 -0700, KUROSAKA Teruhiko wrote:
> Here's a problem I see in this process....

The problem is that none of us have several hours a week to devote to Struts development right now. On a regular basis, I can schedule two hours a week, but, with everything else on my plate, that's all I can afford. :(

If I see someone who's been with us for a while, and is taking an interest in DEV issues, then they get nominated fairly quickly. Niall was our most recent vic^G^G^G volunteer. :) But qualified candidates are few and far between. 

Something people have been telling us very loudly and very clearly on this list is that Struts is too difficult to build. The professional developers who can help us most aretoo busy to learn the idiosyncrasies of our build process.Toward that end, there is now a simplified build.properties template (build.properties.sample.lib) which busy people might find easier to use. 

I believe completing the work on our Maven build will also help, since more and more professional teams are using Maven now. But to do Maven right, we need to standardize the build tree, which is on the agenda for 1.3.x. 

So, the best way to move this process along is to play test the 1.2.1 release hard against your own apps, and tell us what you find. The sooner 1.2.x is stable, the sooner we can move on (as Martin said) "to bigger and better things".

-Ted..


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org


Re: Struts 1.2.1 release? - patches take-up

Posted by KUROSAKA Teruhiko <ku...@bhlab.com>.
Roberto and all,

> Given that the committers are busy people, I'd guess one way to get 
 > a patch considered is to actively seek out struts developers who are
 > experiencing the problem that your patch fixes, and get them to test
 > it for you - you're doing them a favour, and if several of them
 > add a 'works for me' to the ticket, there's a better chance it'll
 > get noticed by the commiters.

Here's a problem I see in this process....
My patch (for 29824, you guesset it right) is to make
it easy for casual struts developers to use Struts.
The target audience is not serious developers.  They
are not interested in (or even capable of)  building Struts
libraries.  They would rather apply a workaround than
building Struts by themselves.
Is it OK that I create a personal version of Struts that
has my patch applied and publish the binary from my
private site?


> Would I be right in assuming your patch is the one on bug 29824 - 
 > that handles parameters that are not encoded in ISO-8859-1? That
> actually sounds like it /might/ solve a problem I recently had with 
 > struts - a form was turning the acute 'e' in 'café' into garbage, hmm!

Your problem is probably due to something else.  The offending
character in your problem is part of ISO-8859-1
which is a default charset; my patch would not fix your problem.
If you tell me your problem (in individual email), I can take a look.

Regards,
-- 
KUROSAKA ("Kuro") Teruhiko, San Francisco, California, USA
Internationalization Consultant --- now available for new contracts!
http://www.bhlab.com/


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org