You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Nate Cole <nc...@hortonworks.com> on 2014/08/18 01:51:24 UTC
Review Request 24788: Alerts: groundwork for alert collection
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24788/
-----------------------------------------------------------
Review request for Ambari and Jonathan Hurley.
Bugs: AMBARI-6887
https://issues.apache.org/jira/browse/AMBARI-6887
Repository: ambari
Description
-------
Add groundwork for alerts, including APScheduler 2.1.2 (3.0.0 has many "bad" dependencies, and 2.1.2 requires none).
Diffs
-----
ambari-agent/pom.xml c98af34
ambari-agent/src/main/python/ambari_agent/AlertSchedulerHandler.py PRE-CREATION
ambari-agent/src/main/python/ambari_agent/Controller.py 87af939
ambari-agent/src/main/python/ambari_agent/alerts/__init__.py PRE-CREATION
ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py PRE-CREATION
ambari-agent/src/main/python/ambari_agent/alerts/port_alert.py PRE-CREATION
ambari-agent/src/main/python/ambari_agent/apscheduler/__init__.py PRE-CREATION
ambari-agent/src/main/python/ambari_agent/apscheduler/events.py PRE-CREATION
ambari-agent/src/main/python/ambari_agent/apscheduler/job.py PRE-CREATION
ambari-agent/src/main/python/ambari_agent/apscheduler/jobstores/__init__.py PRE-CREATION
ambari-agent/src/main/python/ambari_agent/apscheduler/jobstores/base.py PRE-CREATION
ambari-agent/src/main/python/ambari_agent/apscheduler/jobstores/mongodb_store.py PRE-CREATION
ambari-agent/src/main/python/ambari_agent/apscheduler/jobstores/ram_store.py PRE-CREATION
ambari-agent/src/main/python/ambari_agent/apscheduler/jobstores/redis_store.py PRE-CREATION
ambari-agent/src/main/python/ambari_agent/apscheduler/jobstores/shelve_store.py PRE-CREATION
ambari-agent/src/main/python/ambari_agent/apscheduler/jobstores/sqlalchemy_store.py PRE-CREATION
ambari-agent/src/main/python/ambari_agent/apscheduler/scheduler.py PRE-CREATION
ambari-agent/src/main/python/ambari_agent/apscheduler/threadpool.py PRE-CREATION
ambari-agent/src/main/python/ambari_agent/apscheduler/triggers/__init__.py PRE-CREATION
ambari-agent/src/main/python/ambari_agent/apscheduler/triggers/cron/__init__.py PRE-CREATION
ambari-agent/src/main/python/ambari_agent/apscheduler/triggers/cron/expressions.py PRE-CREATION
ambari-agent/src/main/python/ambari_agent/apscheduler/triggers/cron/fields.py PRE-CREATION
ambari-agent/src/main/python/ambari_agent/apscheduler/triggers/interval.py PRE-CREATION
ambari-agent/src/main/python/ambari_agent/apscheduler/triggers/simple.py PRE-CREATION
ambari-agent/src/main/python/ambari_agent/apscheduler/util.py PRE-CREATION
ambari-agent/src/test/python/ambari_agent/TestAlerts.py PRE-CREATION
ambari-agent/src/test/python/ambari_agent/dummy_files/alert_definitions.json PRE-CREATION
Diff: https://reviews.apache.org/r/24788/diff/
Testing
-------
Only basic tests for AlertSchedulerHandler and PortAlerts. Metric and script types will come later. Manual testing command line and with running agent code.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 9.689s
[INFO] Finished at: Sun Aug 17 19:46:42 EDT 2014
[INFO] Final Memory: 7M/81M
[INFO] ------------------------------------------------------------------------
Thanks,
Nate Cole
Re: Review Request 24788: Alerts: groundwork for alert collection
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24788/#review50873
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On Aug. 17, 2014, 7:51 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24788/
> -----------------------------------------------------------
>
> (Updated Aug. 17, 2014, 7:51 p.m.)
>
>
> Review request for Ambari and Jonathan Hurley.
>
>
> Bugs: AMBARI-6887
> https://issues.apache.org/jira/browse/AMBARI-6887
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add groundwork for alerts, including APScheduler 2.1.2 (3.0.0 has many "bad" dependencies, and 2.1.2 requires none).
>
>
> Diffs
> -----
>
> ambari-agent/pom.xml c98af34
> ambari-agent/src/main/python/ambari_agent/AlertSchedulerHandler.py PRE-CREATION
> ambari-agent/src/main/python/ambari_agent/Controller.py 87af939
> ambari-agent/src/main/python/ambari_agent/alerts/__init__.py PRE-CREATION
> ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py PRE-CREATION
> ambari-agent/src/main/python/ambari_agent/alerts/port_alert.py PRE-CREATION
> ambari-agent/src/main/python/ambari_agent/apscheduler/__init__.py PRE-CREATION
> ambari-agent/src/main/python/ambari_agent/apscheduler/events.py PRE-CREATION
> ambari-agent/src/main/python/ambari_agent/apscheduler/job.py PRE-CREATION
> ambari-agent/src/main/python/ambari_agent/apscheduler/jobstores/__init__.py PRE-CREATION
> ambari-agent/src/main/python/ambari_agent/apscheduler/jobstores/base.py PRE-CREATION
> ambari-agent/src/main/python/ambari_agent/apscheduler/jobstores/mongodb_store.py PRE-CREATION
> ambari-agent/src/main/python/ambari_agent/apscheduler/jobstores/ram_store.py PRE-CREATION
> ambari-agent/src/main/python/ambari_agent/apscheduler/jobstores/redis_store.py PRE-CREATION
> ambari-agent/src/main/python/ambari_agent/apscheduler/jobstores/shelve_store.py PRE-CREATION
> ambari-agent/src/main/python/ambari_agent/apscheduler/jobstores/sqlalchemy_store.py PRE-CREATION
> ambari-agent/src/main/python/ambari_agent/apscheduler/scheduler.py PRE-CREATION
> ambari-agent/src/main/python/ambari_agent/apscheduler/threadpool.py PRE-CREATION
> ambari-agent/src/main/python/ambari_agent/apscheduler/triggers/__init__.py PRE-CREATION
> ambari-agent/src/main/python/ambari_agent/apscheduler/triggers/cron/__init__.py PRE-CREATION
> ambari-agent/src/main/python/ambari_agent/apscheduler/triggers/cron/expressions.py PRE-CREATION
> ambari-agent/src/main/python/ambari_agent/apscheduler/triggers/cron/fields.py PRE-CREATION
> ambari-agent/src/main/python/ambari_agent/apscheduler/triggers/interval.py PRE-CREATION
> ambari-agent/src/main/python/ambari_agent/apscheduler/triggers/simple.py PRE-CREATION
> ambari-agent/src/main/python/ambari_agent/apscheduler/util.py PRE-CREATION
> ambari-agent/src/test/python/ambari_agent/TestAlerts.py PRE-CREATION
> ambari-agent/src/test/python/ambari_agent/dummy_files/alert_definitions.json PRE-CREATION
>
> Diff: https://reviews.apache.org/r/24788/diff/
>
>
> Testing
> -------
>
> Only basic tests for AlertSchedulerHandler and PortAlerts. Metric and script types will come later. Manual testing command line and with running agent code.
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 9.689s
> [INFO] Finished at: Sun Aug 17 19:46:42 EDT 2014
> [INFO] Final Memory: 7M/81M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>
Re: Review Request 24788: Alerts: groundwork for alert collection
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24788/#review50872
-----------------------------------------------------------
ambari-agent/src/main/python/ambari_agent/AlertSchedulerHandler.py
<https://reviews.apache.org/r/24788/#comment88744>
We might want to expose this as an optional setting in the config;
ambari-agent/src/main/python/ambari_agent/AlertSchedulerHandler.py
<https://reviews.apache.org/r/24788/#comment88745>
Good for development, but might want to use the value from the config long term.
ambari-agent/src/main/python/ambari_agent/alerts/port_alert.py
<https://reviews.apache.org/r/24788/#comment88746>
Should we make it so that collect() has to return a value instead of throwing an exception to indicate a failure?
- Jonathan Hurley
On Aug. 17, 2014, 7:51 p.m., Nate Cole wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24788/
> -----------------------------------------------------------
>
> (Updated Aug. 17, 2014, 7:51 p.m.)
>
>
> Review request for Ambari and Jonathan Hurley.
>
>
> Bugs: AMBARI-6887
> https://issues.apache.org/jira/browse/AMBARI-6887
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add groundwork for alerts, including APScheduler 2.1.2 (3.0.0 has many "bad" dependencies, and 2.1.2 requires none).
>
>
> Diffs
> -----
>
> ambari-agent/pom.xml c98af34
> ambari-agent/src/main/python/ambari_agent/AlertSchedulerHandler.py PRE-CREATION
> ambari-agent/src/main/python/ambari_agent/Controller.py 87af939
> ambari-agent/src/main/python/ambari_agent/alerts/__init__.py PRE-CREATION
> ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py PRE-CREATION
> ambari-agent/src/main/python/ambari_agent/alerts/port_alert.py PRE-CREATION
> ambari-agent/src/main/python/ambari_agent/apscheduler/__init__.py PRE-CREATION
> ambari-agent/src/main/python/ambari_agent/apscheduler/events.py PRE-CREATION
> ambari-agent/src/main/python/ambari_agent/apscheduler/job.py PRE-CREATION
> ambari-agent/src/main/python/ambari_agent/apscheduler/jobstores/__init__.py PRE-CREATION
> ambari-agent/src/main/python/ambari_agent/apscheduler/jobstores/base.py PRE-CREATION
> ambari-agent/src/main/python/ambari_agent/apscheduler/jobstores/mongodb_store.py PRE-CREATION
> ambari-agent/src/main/python/ambari_agent/apscheduler/jobstores/ram_store.py PRE-CREATION
> ambari-agent/src/main/python/ambari_agent/apscheduler/jobstores/redis_store.py PRE-CREATION
> ambari-agent/src/main/python/ambari_agent/apscheduler/jobstores/shelve_store.py PRE-CREATION
> ambari-agent/src/main/python/ambari_agent/apscheduler/jobstores/sqlalchemy_store.py PRE-CREATION
> ambari-agent/src/main/python/ambari_agent/apscheduler/scheduler.py PRE-CREATION
> ambari-agent/src/main/python/ambari_agent/apscheduler/threadpool.py PRE-CREATION
> ambari-agent/src/main/python/ambari_agent/apscheduler/triggers/__init__.py PRE-CREATION
> ambari-agent/src/main/python/ambari_agent/apscheduler/triggers/cron/__init__.py PRE-CREATION
> ambari-agent/src/main/python/ambari_agent/apscheduler/triggers/cron/expressions.py PRE-CREATION
> ambari-agent/src/main/python/ambari_agent/apscheduler/triggers/cron/fields.py PRE-CREATION
> ambari-agent/src/main/python/ambari_agent/apscheduler/triggers/interval.py PRE-CREATION
> ambari-agent/src/main/python/ambari_agent/apscheduler/triggers/simple.py PRE-CREATION
> ambari-agent/src/main/python/ambari_agent/apscheduler/util.py PRE-CREATION
> ambari-agent/src/test/python/ambari_agent/TestAlerts.py PRE-CREATION
> ambari-agent/src/test/python/ambari_agent/dummy_files/alert_definitions.json PRE-CREATION
>
> Diff: https://reviews.apache.org/r/24788/diff/
>
>
> Testing
> -------
>
> Only basic tests for AlertSchedulerHandler and PortAlerts. Metric and script types will come later. Manual testing command line and with running agent code.
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 9.689s
> [INFO] Finished at: Sun Aug 17 19:46:42 EDT 2014
> [INFO] Final Memory: 7M/81M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Nate Cole
>
>