You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/02/22 16:27:23 UTC

[GitHub] [airflow] ashb commented on a change in pull request #7505: [AIRFLOW-6883] Speed up import of airflow.utils.log.file_task_hanlder

ashb commented on a change in pull request #7505: [AIRFLOW-6883] Speed up import of airflow.utils.log.file_task_hanlder
URL: https://github.com/apache/airflow/pull/7505#discussion_r382924304
 
 

 ##########
 File path: airflow/utils/log/file_task_handler.py
 ##########
 @@ -18,15 +18,17 @@
 """File logging handler for tasks."""
 import logging
 import os
-from typing import Optional
 
 Review comment:
   Why not both? This is what the TYPE_CHECKING was designed for.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services