[GitHub] [ozone] smengcl commented on a diff in pull request #4065: HDDS-7507. [Snapshot] Implement List Snapshot API Pagination

["smengcl (via GitHub)" <gi...@apache.org>]

smengcl commented on code in PR #4065:
URL: https://github.com/apache/ozone/pull/4065#discussion_r1113597003


##########
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/ObjectStore.java:
##########
@@ -551,14 +551,81 @@ public void deleteSnapshot(String volumeName,
 
   /**
    * List snapshots in a volume/bucket.
-   * @param volumeName volume name
-   * @param bucketName bucket name
-   * @return list of snapshots for volume/bucket snapshotpath.
+   * @param volumeName     volume name
+   * @param bucketName     bucket name
+   * @param snapshotPrefix snapshot prefix to match

Review Comment:
   > Another parameter that could be helpful is to return snapshots that were created between two time timestamps.
   
   @prashantpogde We could have another overloaded `listSnapshot()` that takes such params in another jira.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org