You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by nickva <gi...@git.apache.org> on 2016/10/06 22:09:54 UTC
[GitHub] couchdb-documentation pull request #78: Update max_document_size description...
GitHub user nickva opened a pull request:
https://github.com/apache/couchdb-documentation/pull/78
Update max_document_size description with correct semantics
`max_document_size` is a misnomer and is actually implemented as the
equivalent of `max_http_recv_body_size`. That is, it checks the total
HTTP request body size. In case of multiple documents (_bulk_docs)
or attachments, there could be a large discrepancy between the two which can
and that can be surprising for the users.
In the future we could deprecate this setting, rename it, or have an actual
check for individual document sizes, however for now it is better to inform
users of current behavior.
COUCHDB-3174
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloudant/couchdb-documentation couchdb-3174
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-documentation/pull/78.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #78
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-documentation issue #78: Update max_document_size description with c...
Posted by nickva <gi...@git.apache.org>.
Github user nickva commented on the issue:
https://github.com/apache/couchdb-documentation/pull/78
Docs were broken from 2 commits back or so:
Made a pr with the fix:
https://github.com/apache/couchdb-documentation/pull/79
That one has the build all green
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-documentation pull request #78: Update max_document_size description...
Posted by davisp <gi...@git.apache.org>.
Github user davisp commented on a diff in the pull request:
https://github.com/apache/couchdb-documentation/pull/78#discussion_r82298531
--- Diff: src/config/couchdb.rst ---
@@ -105,15 +105,21 @@ Base CouchDB Options
[couchdb]
max_dbs_open = 100
- .. config:option:: max_document_size :: Maximum document size
-
- .. versionchanged:: 1.3 This option now actually works.
-
- Defines a maximum size for JSON documents, in bytes. This limit does
- not apply to attachments, since they are transferred as a stream of
- chunks. If you set this to a small value, you might be unable to modify
- configuration options, database security and other larger documents
- until a larger value is restored by editing the configuration file. ::
+ .. config:option:: max_document_size :: Maximum HTTP request body size
+
+ .. versionchanged:: 2.1
--- End diff --
2.0.1 me thinks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-documentation pull request #78: Update max_document_size description...
Posted by nickva <gi...@git.apache.org>.
Github user nickva closed the pull request at:
https://github.com/apache/couchdb-documentation/pull/78
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-documentation issue #78: Update max_document_size description with c...
Posted by nickva <gi...@git.apache.org>.
Github user nickva commented on the issue:
https://github.com/apache/couchdb-documentation/pull/78
pdf and html generation has warnings, but it's from a few commits before. Same failure as in previous builds:
https://travis-ci.org/apache/couchdb-documentation/builds
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-documentation issue #78: Update max_document_size description with c...
Posted by davisp <gi...@git.apache.org>.
Github user davisp commented on the issue:
https://github.com/apache/couchdb-documentation/pull/78
+1 to merge assuming the travis-ci checks pass.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---