You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by sunjincheng121 <gi...@git.apache.org> on 2017/09/05 01:11:22 UTC

[GitHub] flink pull request #4640: [FLINK-7572][table]Improve TableSchema and FlinkTa...

GitHub user sunjincheng121 opened a pull request:

    https://github.com/apache/flink/pull/4640

    [FLINK-7572][table]Improve TableSchema and FlinkTable validation exce…

    ## What is the purpose of the change
    Currently, the exception message of `TableScheam` and `FlinkTable` a little confusing,In this PR. we want improve the exception message .
    
    
    ## Brief change log
    
      - *Improve TableSchema column name and column type validation exception message*
      - *Improve TableSchema column name duplicate validation exception message*
      - *Improve FlinkTable field name and field type validation exception message*
      - *Improve FlinkTable field name duplicate validation exception message*
    
    ## Verifying this change
    - This change is verified by the new  `TableSchemaValidationTest#testColumnNameAndColumnTypeNotEqual` `TableSchemaValidationTest#testColumnNamesDuplicate` and `FlinkTableValidationTest#testFieldNamesDuplicate`.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: ( no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not documented)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sunjincheng121/flink FLINK-7572-PR

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4640.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4640
    
----
commit 555828aa6a257921f52fb87b8ab5f2afff78eee0
Author: sunjincheng121 <su...@gmail.com>
Date:   2017-09-05T00:55:03Z

    [FLINK-7572][table]Improve TableSchema and FlinkTable validation exception message

----


---

[GitHub] flink issue #4640: [FLINK-7572][table]Improve TableSchema and FlinkTable val...

Posted by fhueske <gi...@git.apache.org>.

Github user fhueske commented on the issue:

    https://github.com/apache/flink/pull/4640
  
    Thanks for the PR @sunjincheng121. I'll merge this.


---

[GitHub] flink pull request #4640: [FLINK-7572][table]Improve TableSchema and FlinkTa...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/4640


---