You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "Will-Lo (via GitHub)" <gi...@apache.org> on 2023/01/23 18:23:35 UTC

[GitHub] [gobblin] Will-Lo opened a new pull request, #3628: [GOBBLIN-1768] Fix constructor in KafkaJobStatusMonitorFactory so that it can be inj…

Will-Lo opened a new pull request, #3628:
URL: https://github.com/apache/gobblin/pull/3628

   …ected
   
   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
   
   
   ### JIRA
   - [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-1768
   
   
   ### Description
   - [x] Here are some details about my PR, including screenshots (if applicable):
   
   There is a bug in the KafkaJobStatusMonitorFactory that prevents it from being initialized due to a runtime bug with Guice dependencies. This PR fixes that issue by fixing the injected constructor.
   
   ### Tests
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   
   ### Commits
   - [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [gobblin] Will-Lo merged pull request #3628: [GOBBLIN-1768] Fix constructor in KafkaJobStatusMonitorFactory so that it can be inj…

Posted by "Will-Lo (via GitHub)" <gi...@apache.org>.
Will-Lo merged PR #3628:
URL: https://github.com/apache/gobblin/pull/3628


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org