You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/08/26 01:40:12 UTC

[GitHub] [incubator-doris] yangzhg commented on a change in pull request #6504: [Feature]support three functions of json

yangzhg commented on a change in pull request #6504:
URL: https://github.com/apache/incubator-doris/pull/6504#discussion_r696224212



##########
File path: be/src/exprs/json_functions.h
##########
@@ -122,6 +129,8 @@ class JsonFunctions {
                                          bool is_insert_null = false);
     static void get_parsed_paths(const std::vector<std::string>& path_exprs,
                                  std::vector<JsonPath>* parsed_paths);
+    static void parse_str_with_flag(std::string& result, const std::string& arg,

Review comment:
       If you want to change the value of string, use pointer instead of reference




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org