You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Bryan Duxbury (JIRA)" <ji...@apache.org> on 2010/02/11 00:42:33 UTC
[jira] Created: (THRIFT-701) Generated classes take up more space
in jar than needed
Generated classes take up more space in jar than needed
-------------------------------------------------------
Key: THRIFT-701
URL: https://issues.apache.org/jira/browse/THRIFT-701
Project: Thrift
Issue Type: Improvement
Affects Versions: 0.2
Reporter: Bryan Duxbury
Assignee: Bryan Duxbury
Fix For: 0.3
In glancing at one of our jars of generated Thrift class files, I noticed that it was pretty huge. Further digging showed that while certainly most of the bulk was attributable to the number of class files we have, part of it was due to lots of unnecessary internal classes. This is because we use a specific syntax for defining some maps inline in structs and enums.
Since this is only syntactic sugar, I think it would make sense to write a tiny bit of helper code and avoid the need for a dynamic internal class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (THRIFT-701) Generated classes take up more space in
jar than needed
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury closed THRIFT-701.
--------------------------------
Resolution: Fixed
I just committed a fix for this in r926466.
> Generated classes take up more space in jar than needed
> -------------------------------------------------------
>
> Key: THRIFT-701
> URL: https://issues.apache.org/jira/browse/THRIFT-701
> Project: Thrift
> Issue Type: Improvement
> Affects Versions: 0.2
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Fix For: 0.3
>
>
> In glancing at one of our jars of generated Thrift class files, I noticed that it was pretty huge. Further digging showed that while certainly most of the bulk was attributable to the number of class files we have, part of it was due to lots of unnecessary internal classes. This is because we use a specific syntax for defining some maps inline in structs and enums.
> Since this is only syntactic sugar, I think it would make sense to write a tiny bit of helper code and avoid the need for a dynamic internal class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.