You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (Created) (JIRA)" <ji...@apache.org> on 2011/11/01 05:08:32 UTC
[jira] [Created] (CASSANDRA-3437) invalidate / unregisterSSTables
is confused
invalidate / unregisterSSTables is confused
-------------------------------------------
Key: CASSANDRA-3437
URL: https://issues.apache.org/jira/browse/CASSANDRA-3437
Project: Cassandra
Issue Type: Bug
Components: Core
Reporter: Jonathan Ellis
Assignee: Jonathan Ellis
Fix For: 1.0.2
invalidate doesn't call unregisterSSTables, and vice versa, making it easy to get yourself into a situation that "shouldn't happen." This is causing test failures post-CASSANDRA-3116.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3437) invalidate / unregisterSSTables
is confused
Posted by "Jonathan Ellis (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145531#comment-13145531 ]
Jonathan Ellis commented on CASSANDRA-3437:
-------------------------------------------
p0 problem again? Just updated 1.0 and it applies cleanly.
> invalidate / unregisterSSTables is confused
> -------------------------------------------
>
> Key: CASSANDRA-3437
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3437
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.0.0
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Labels: indexing
> Fix For: 1.0.3
>
> Attachments: 3437-v2.txt, 3437.txt
>
>
> invalidate doesn't call unregisterSSTables, and vice versa, making it easy to get yourself into a situation that "shouldn't happen." This is causing test failures post-CASSANDRA-3116.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3437) invalidate / unregisterSSTables
is confused
Posted by "Sylvain Lebresne (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145552#comment-13145552 ]
Sylvain Lebresne commented on CASSANDRA-3437:
---------------------------------------------
Not a p0 problem this time but somehow I messed up updating my 1.0 branches, not sure how. Anyway, it does apply, +1.
> invalidate / unregisterSSTables is confused
> -------------------------------------------
>
> Key: CASSANDRA-3437
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3437
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.0.0
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Labels: indexing
> Fix For: 1.0.3
>
> Attachments: 3437-v2.txt, 3437.txt
>
>
> invalidate doesn't call unregisterSSTables, and vice versa, making it easy to get yourself into a situation that "shouldn't happen." This is causing test failures post-CASSANDRA-3116.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3437) invalidate / unregisterSSTables
is confused
Posted by "Sylvain Lebresne (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145338#comment-13145338 ]
Sylvain Lebresne commented on CASSANDRA-3437:
---------------------------------------------
I haven't been to apply v2 cleanly on 1.0, so I haven't checked the unit tests in particular, but from reading the patch it lgtm.
> invalidate / unregisterSSTables is confused
> -------------------------------------------
>
> Key: CASSANDRA-3437
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3437
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.0.0
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Labels: indexing
> Fix For: 1.0.3
>
> Attachments: 3437-v2.txt, 3437.txt
>
>
> invalidate doesn't call unregisterSSTables, and vice versa, making it easy to get yourself into a situation that "shouldn't happen." This is causing test failures post-CASSANDRA-3116.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-3437) invalidate / unregisterSSTables
is confused
Posted by "Jonathan Ellis (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-3437:
--------------------------------------
Attachment: 3437-v2.txt
> invalidate / unregisterSSTables is confused
> -------------------------------------------
>
> Key: CASSANDRA-3437
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3437
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.0.0
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Labels: indexing
> Fix For: 1.0.3
>
> Attachments: 3437-v2.txt, 3437.txt
>
>
> invalidate doesn't call unregisterSSTables, and vice versa, making it easy to get yourself into a situation that "shouldn't happen." This is causing test failures post-CASSANDRA-3116.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-3437) invalidate / unregisterSSTables
is confused
Posted by "Jonathan Ellis (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-3437:
--------------------------------------
Attachment: 3437.txt
patch to make invalidate do the equivalent of unregisterSSTables and removes the latter as a separate method. Uses in tests were replaced by calling clearUnsafe. Did have to extract CFS.unregisterMBean as a separate method for KeyCacheTest's benefit.
Patch also renames IM.unregisterMBean -> IM.invalidate.
> invalidate / unregisterSSTables is confused
> -------------------------------------------
>
> Key: CASSANDRA-3437
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3437
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 1.0.2
>
> Attachments: 3437.txt
>
>
> invalidate doesn't call unregisterSSTables, and vice versa, making it easy to get yourself into a situation that "shouldn't happen." This is causing test failures post-CASSANDRA-3116.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3437) invalidate / unregisterSSTables
is confused
Posted by "Jonathan Ellis (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13144888#comment-13144888 ]
Jonathan Ellis commented on CASSANDRA-3437:
-------------------------------------------
v2 is against 1.0 branch. Caught a comment change or two that v1 didn't but otherwise the substance is the same.
> invalidate / unregisterSSTables is confused
> -------------------------------------------
>
> Key: CASSANDRA-3437
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3437
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.0.0
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Labels: indexing
> Fix For: 1.0.3
>
> Attachments: 3437-v2.txt, 3437.txt
>
>
> invalidate doesn't call unregisterSSTables, and vice versa, making it easy to get yourself into a situation that "shouldn't happen." This is causing test failures post-CASSANDRA-3116.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira