You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by vesense <gi...@git.apache.org> on 2018/04/03 03:17:57 UTC

[GitHub] storm pull request #2518: STORM-2902: Some improvements for storm-rocketmq m...

Github user vesense commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2518#discussion_r178704108
  
    --- Diff: external/storm-rocketmq/src/main/java/org/apache/storm/rocketmq/RocketMqConfig.java ---
    @@ -23,28 +23,20 @@
     import java.util.Properties;
     import java.util.UUID;
     
    +import org.apache.commons.lang.StringUtils;
     import org.apache.commons.lang.Validate;
     import org.apache.rocketmq.client.ClientConfig;
     import org.apache.rocketmq.client.consumer.DefaultMQPushConsumer;
     import org.apache.rocketmq.client.exception.MQClientException;
     import org.apache.rocketmq.client.producer.DefaultMQProducer;
     import org.apache.rocketmq.common.consumer.ConsumeFromWhere;
    -import org.apache.rocketmq.remoting.common.RemotingUtil;
     
     /**
      * RocketMqConfig for Consumer/Producer.
      */
    --- End diff --
    
    @vongosling This is limited by the storm checkstyle rule `AbbreviationAsWordInName`. Refer to https://github.com/apache/storm/blob/master/storm-checkstyle/src/main/resources/storm/storm_checkstyle.xml#L213


---