[GitHub] [skywalking] wu-sheng edited a comment on issue #4462: [Agent Core] Support lazy ContextCarrier injection and lazy peer id setting

[GitBox <gi...@apache.org>]

wu-sheng edited a comment on issue #4462: [Agent Core] Support lazy ContextCarrier injection and lazy peer id setting 
URL: https://github.com/apache/skywalking/pull/4462#issuecomment-596180895
 
 
   > return exitSpan.getOperatioName() != null && exitSpan.getPeer() != null;
   
   I prefer you use the plugin internal variables rather than using `exitSpan#get*`. @huangyoje 
   Because the peer name could be exchanged to peer id. So avoid of using that, use something you could control.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services