You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "wjgan7 (via GitHub)" <gi...@apache.org> on 2026/08/13 23:03:14 UTC

[PR] [SPARK-XXXX][UI] Fix filter and min,med,max table interaction [spark]

wjgan7 opened a new pull request, #57997:
URL: https://github.com/apache/spark/pull/57997

   ### What changes were proposed in this pull request?
   
   Change the way filtering metrics is done in `spark-sql-viz.js` to fix bug with metrics showing blank
   
   ### Why are the changes needed?
   
   https://github.com/apache/spark/pull/54887 introduced a filter for SQL metrics. It is very useful, but when a metric has min, med, and max values, it shows the metric as blank
   
   <img width="581" height="68" alt="image" src="https://github.com/user-attachments/assets/a6563927-a048-4fac-b514-e4dab8f4d6d9" />
   
   <img width="611" height="111" alt="image" src="https://github.com/user-attachments/assets/12f224bd-482d-41b5-9564-c2a7a959113a" />
   
   ### Does this PR introduce _any_ user-facing change?
   
   Yes, it affects the Spark UI
   
   ### How was this patch tested?
   
   - Added test in ui-test/
   - Verified locally
   
   <img width="607" height="134" alt="image" src="https://github.com/user-attachments/assets/3808e7bb-6372-4334-84ee-247de02316ab" />
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   Generated-by: Claude Code / Opus 4.8
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-58775][UI] Fix SQL metrics filter and min,med,max table interaction [spark]

Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b commented on PR #57997:
URL: https://github.com/apache/spark/pull/57997#issuecomment-5492799078

   **Merge Summary:**
   - merged into master https://github.com/apache/spark/commit/e484d9adfe341476a84a151444996944f88e6135
   - merged into branch-4.x https://github.com/apache/spark/commit/ce91b19bf911b63effbbd48ef67e14516245aa36
   - merged into branch-4.3 https://github.com/apache/spark/commit/b489b6bdf2b89101ff3648fb2e4a460fc8dab769
   - merged into branch-4.2 https://github.com/apache/spark/commit/5f21938441330a7b6adbedb6f283217165f6c03d
   
   *Posted by `merge_spark_pr.py`*


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-58775][UI] Fix SQL metrics filter and min,med,max table interaction [spark]

Posted by "wjgan7 (via GitHub)" <gi...@apache.org>.
wjgan7 commented on PR #57997:
URL: https://github.com/apache/spark/pull/57997#issuecomment-5317790546

   @uros-b @yaooqinn thanks for the review! Can we merge the PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-58775][UI] Fix SQL metrics filter and min,med,max table interaction [spark]

Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b closed pull request #57997: [SPARK-58775][UI] Fix SQL metrics filter and min,med,max table interaction
URL: https://github.com/apache/spark/pull/57997


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org