You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/05/26 21:01:03 UTC
[GitHub] [pulsar] nicoloboschi opened a new pull request, #15810: [branch-2.10][fix][common] Add back FutureUtil#waitForAll and FutureUtil#waitForAny methods with List parameter
nicoloboschi opened a new pull request, #15810:
URL: https://github.com/apache/pulsar/pull/15810
### Motivation
In https://github.com/apache/pulsar/pull/15329 FutureUtil#waitForAll and FutureUtil#waitForAny methods with List parameter have been removed.
If an application uses one of that method, it won't be able to switch from 2.10.0 to 2.10.1 (it will get a NoSuchMethodError exception).
Even if those methods are intedend to internal use only, this kind of breaking changes are not justified in a patch release.
For example both Stream Native KoP and Datastax Starlight for Kafka use the `waitForAll` method.
### Modifications
- Re add the List specific version of those methods
- [x] `doc-not-needed`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nicoloboschi closed pull request #15810: [branch-2.10][fix][common] Add back FutureUtil#waitForAll and FutureUtil#waitForAny methods with List parameter
Posted by GitBox <gi...@apache.org>.
nicoloboschi closed pull request #15810: [branch-2.10][fix][common] Add back FutureUtil#waitForAll and FutureUtil#waitForAny methods with List parameter
URL: https://github.com/apache/pulsar/pull/15810
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #15810: [branch-2.10][fix][common] Add back FutureUtil#waitForAll and FutureUtil#waitForAny methods with List parameter
Posted by GitBox <gi...@apache.org>.
eolivelli commented on PR #15810:
URL: https://github.com/apache/pulsar/pull/15810#issuecomment-1139062487
@BewareMyPower this patch fixes KoP on 2.10.1
PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on pull request #15810: [branch-2.10][fix][common] Add back FutureUtil#waitForAll and FutureUtil#waitForAny methods with List parameter
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on PR #15810:
URL: https://github.com/apache/pulsar/pull/15810#issuecomment-1139220819
I agree. We should not introduce the API changes in patch releases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nicoloboschi commented on pull request #15810: [branch-2.10][fix][common] Add back FutureUtil#waitForAll and FutureUtil#waitForAny methods with List parameter
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on PR #15810:
URL: https://github.com/apache/pulsar/pull/15810#issuecomment-1139104938
The deprecated annotation makes sense.
The revert is not possible because the new method is used by https://github.com/apache/pulsar/commit/836ed1e25fcfecb86ea162f3b35b8978ed7e406a
There's a cherry-pick issue on branch-2.10 (not related to this pull) that makes the CI fails, will fix it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nicoloboschi commented on pull request #15810: [branch-2.10][fix][common] Add back FutureUtil#waitForAll and FutureUtil#waitForAny methods with List parameter
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on PR #15810:
URL: https://github.com/apache/pulsar/pull/15810#issuecomment-1139047913
@mattisonchao @eolivelli PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nicoloboschi merged pull request #15810: [branch-2.10][fix][common] Add back FutureUtil#waitForAll and FutureUtil#waitForAny methods with List parameter
Posted by GitBox <gi...@apache.org>.
nicoloboschi merged PR #15810:
URL: https://github.com/apache/pulsar/pull/15810
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org