You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Namit Jain (JIRA)" <ji...@apache.org> on 2008/12/12 00:29:44 UTC

[jira] Created: (HIVE-168) join on a subquery with a group by does not work

join on a subquery with a group by does not work
------------------------------------------------

                 Key: HIVE-168
                 URL: https://issues.apache.org/jira/browse/HIVE-168
             Project: Hadoop Hive
          Issue Type: Bug
            Reporter: Namit Jain
            Assignee: Namit Jain


 SELECT a.key, a.value, b.key, b.value
 FROM 
  (
  SELECT src1.key as key, count(src1.value) AS value FROM src src1 group by src1.key
  ) a
 FULL OUTER JOIN 
 (
  SELECT src2.key as key, count(distinct(src2.value)) AS value 
  FROM src1 src2 group by src2.key
 ) b 
 ON (a.key = b.key);


does not generate the plan correctly

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-168) join on a subquery with a group by does not work

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Namit Jain updated HIVE-168:
----------------------------

    Status: Patch Available  (was: Open)

> join on a subquery with a group by does not work
> ------------------------------------------------
>
>                 Key: HIVE-168
>                 URL: https://issues.apache.org/jira/browse/HIVE-168
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: Namit Jain
>         Attachments: 168.patch, patch2
>
>
>  SELECT a.key, a.value, b.key, b.value
>  FROM 
>   (
>   SELECT src1.key as key, count(src1.value) AS value FROM src src1 group by src1.key
>   ) a
>  FULL OUTER JOIN 
>  (
>   SELECT src2.key as key, count(distinct(src2.value)) AS value 
>   FROM src1 src2 group by src2.key
>  ) b 
>  ON (a.key = b.key);
> does not generate the plan correctly

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-168) join on a subquery with a group by does not work

Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carl Steinbach updated HIVE-168:
--------------------------------

    Fix Version/s: 0.3.0

> join on a subquery with a group by does not work
> ------------------------------------------------
>
>                 Key: HIVE-168
>                 URL: https://issues.apache.org/jira/browse/HIVE-168
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: Namit Jain
>             Fix For: 0.3.0
>
>         Attachments: 168.patch, patch2, patch3
>
>
>  SELECT a.key, a.value, b.key, b.value
>  FROM 
>   (
>   SELECT src1.key as key, count(src1.value) AS value FROM src src1 group by src1.key
>   ) a
>  FULL OUTER JOIN 
>  (
>   SELECT src2.key as key, count(distinct(src2.value)) AS value 
>   FROM src1 src2 group by src2.key
>  ) b 
>  ON (a.key = b.key);
> does not generate the plan correctly

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-168) join on a subquery with a group by does not work

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Namit Jain updated HIVE-168:
----------------------------

    Attachment: patch3

> join on a subquery with a group by does not work
> ------------------------------------------------
>
>                 Key: HIVE-168
>                 URL: https://issues.apache.org/jira/browse/HIVE-168
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: Namit Jain
>         Attachments: 168.patch, patch2, patch3
>
>
>  SELECT a.key, a.value, b.key, b.value
>  FROM 
>   (
>   SELECT src1.key as key, count(src1.value) AS value FROM src src1 group by src1.key
>   ) a
>  FULL OUTER JOIN 
>  (
>   SELECT src2.key as key, count(distinct(src2.value)) AS value 
>   FROM src1 src2 group by src2.key
>  ) b 
>  ON (a.key = b.key);
> does not generate the plan correctly

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-168) join on a subquery with a group by does not work

Posted by "Ashish Thusoo (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656151#action_12656151 ] 

Ashish Thusoo commented on HIVE-168:
------------------------------------

A couple of minor comments:

1. mergeTask function is actually also doing a splitTask, so we should name it appropriately.
2. setCurrTasks is done twice (inside mergeTask and also in the callers). We should just get rid of the calls in the callers.\

Also please file a separate JIRA to make the explain output better (so that the tasks and seen in the order of dependencies instead of the order of names).


> join on a subquery with a group by does not work
> ------------------------------------------------
>
>                 Key: HIVE-168
>                 URL: https://issues.apache.org/jira/browse/HIVE-168
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: Namit Jain
>         Attachments: 168.patch, patch2
>
>
>  SELECT a.key, a.value, b.key, b.value
>  FROM 
>   (
>   SELECT src1.key as key, count(src1.value) AS value FROM src src1 group by src1.key
>   ) a
>  FULL OUTER JOIN 
>  (
>   SELECT src2.key as key, count(distinct(src2.value)) AS value 
>   FROM src1 src2 group by src2.key
>  ) b 
>  ON (a.key = b.key);
> does not generate the plan correctly

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-168) join on a subquery with a group by does not work

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Namit Jain updated HIVE-168:
----------------------------

    Attachment: 168.patch

> join on a subquery with a group by does not work
> ------------------------------------------------
>
>                 Key: HIVE-168
>                 URL: https://issues.apache.org/jira/browse/HIVE-168
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: Namit Jain
>         Attachments: 168.patch
>
>
>  SELECT a.key, a.value, b.key, b.value
>  FROM 
>   (
>   SELECT src1.key as key, count(src1.value) AS value FROM src src1 group by src1.key
>   ) a
>  FULL OUTER JOIN 
>  (
>   SELECT src2.key as key, count(distinct(src2.value)) AS value 
>   FROM src1 src2 group by src2.key
>  ) b 
>  ON (a.key = b.key);
> does not generate the plan correctly

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-168) join on a subquery with a group by does not work

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Namit Jain updated HIVE-168:
----------------------------

    Status: Open  (was: Patch Available)

> join on a subquery with a group by does not work
> ------------------------------------------------
>
>                 Key: HIVE-168
>                 URL: https://issues.apache.org/jira/browse/HIVE-168
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: Namit Jain
>         Attachments: 168.patch, patch2, patch3
>
>
>  SELECT a.key, a.value, b.key, b.value
>  FROM 
>   (
>   SELECT src1.key as key, count(src1.value) AS value FROM src src1 group by src1.key
>   ) a
>  FULL OUTER JOIN 
>  (
>   SELECT src2.key as key, count(distinct(src2.value)) AS value 
>   FROM src1 src2 group by src2.key
>  ) b 
>  ON (a.key = b.key);
> does not generate the plan correctly

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-168) join on a subquery with a group by does not work

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Namit Jain updated HIVE-168:
----------------------------

    Component/s: Query Processor

> join on a subquery with a group by does not work
> ------------------------------------------------
>
>                 Key: HIVE-168
>                 URL: https://issues.apache.org/jira/browse/HIVE-168
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: Namit Jain
>
>  SELECT a.key, a.value, b.key, b.value
>  FROM 
>   (
>   SELECT src1.key as key, count(src1.value) AS value FROM src src1 group by src1.key
>   ) a
>  FULL OUTER JOIN 
>  (
>   SELECT src2.key as key, count(distinct(src2.value)) AS value 
>   FROM src1 src2 group by src2.key
>  ) b 
>  ON (a.key = b.key);
> does not generate the plan correctly

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-168) join on a subquery with a group by does not work

Posted by "Ashish Thusoo (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656212#action_12656212 ] 

Ashish Thusoo commented on HIVE-168:
------------------------------------

+1

looks good.

> join on a subquery with a group by does not work
> ------------------------------------------------
>
>                 Key: HIVE-168
>                 URL: https://issues.apache.org/jira/browse/HIVE-168
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: Namit Jain
>         Attachments: 168.patch, patch2, patch3
>
>
>  SELECT a.key, a.value, b.key, b.value
>  FROM 
>   (
>   SELECT src1.key as key, count(src1.value) AS value FROM src src1 group by src1.key
>   ) a
>  FULL OUTER JOIN 
>  (
>   SELECT src2.key as key, count(distinct(src2.value)) AS value 
>   FROM src1 src2 group by src2.key
>  ) b 
>  ON (a.key = b.key);
> does not generate the plan correctly

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-168) join on a subquery with a group by does not work

Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zheng Shao updated HIVE-168:
----------------------------

      Resolution: Fixed
    Hadoop Flags: [Reviewed]
          Status: Resolved  (was: Patch Available)

HIVE-168. Fixed join on a subquery with a group by. (Namit Jain via zshao)

> join on a subquery with a group by does not work
> ------------------------------------------------
>
>                 Key: HIVE-168
>                 URL: https://issues.apache.org/jira/browse/HIVE-168
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: Namit Jain
>         Attachments: 168.patch, patch2, patch3
>
>
>  SELECT a.key, a.value, b.key, b.value
>  FROM 
>   (
>   SELECT src1.key as key, count(src1.value) AS value FROM src src1 group by src1.key
>   ) a
>  FULL OUTER JOIN 
>  (
>   SELECT src2.key as key, count(distinct(src2.value)) AS value 
>   FROM src1 src2 group by src2.key
>  ) b 
>  ON (a.key = b.key);
> does not generate the plan correctly

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-168) join on a subquery with a group by does not work

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Namit Jain updated HIVE-168:
----------------------------

    Status: Open  (was: Patch Available)

> join on a subquery with a group by does not work
> ------------------------------------------------
>
>                 Key: HIVE-168
>                 URL: https://issues.apache.org/jira/browse/HIVE-168
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: Namit Jain
>         Attachments: 168.patch, patch2
>
>
>  SELECT a.key, a.value, b.key, b.value
>  FROM 
>   (
>   SELECT src1.key as key, count(src1.value) AS value FROM src src1 group by src1.key
>   ) a
>  FULL OUTER JOIN 
>  (
>   SELECT src2.key as key, count(distinct(src2.value)) AS value 
>   FROM src1 src2 group by src2.key
>  ) b 
>  ON (a.key = b.key);
> does not generate the plan correctly

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-168) join on a subquery with a group by does not work

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Namit Jain updated HIVE-168:
----------------------------

    Status: Patch Available  (was: Open)

done and filed the new JIRA

https://issues.apache.org/jira/browse/HIVE-173

> join on a subquery with a group by does not work
> ------------------------------------------------
>
>                 Key: HIVE-168
>                 URL: https://issues.apache.org/jira/browse/HIVE-168
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: Namit Jain
>         Attachments: 168.patch, patch2, patch3
>
>
>  SELECT a.key, a.value, b.key, b.value
>  FROM 
>   (
>   SELECT src1.key as key, count(src1.value) AS value FROM src src1 group by src1.key
>   ) a
>  FULL OUTER JOIN 
>  (
>   SELECT src2.key as key, count(distinct(src2.value)) AS value 
>   FROM src1 src2 group by src2.key
>  ) b 
>  ON (a.key = b.key);
> does not generate the plan correctly

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-168) join on a subquery with a group by does not work

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Namit Jain updated HIVE-168:
----------------------------

    Status: Patch Available  (was: Open)

> join on a subquery with a group by does not work
> ------------------------------------------------
>
>                 Key: HIVE-168
>                 URL: https://issues.apache.org/jira/browse/HIVE-168
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: Namit Jain
>         Attachments: 168.patch
>
>
>  SELECT a.key, a.value, b.key, b.value
>  FROM 
>   (
>   SELECT src1.key as key, count(src1.value) AS value FROM src src1 group by src1.key
>   ) a
>  FULL OUTER JOIN 
>  (
>   SELECT src2.key as key, count(distinct(src2.value)) AS value 
>   FROM src1 src2 group by src2.key
>  ) b 
>  ON (a.key = b.key);
> does not generate the plan correctly

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-168) join on a subquery with a group by does not work

Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12656724#action_12656724 ] 

Zheng Shao commented on HIVE-168:
---------------------------------

Committed revision 726784.


> join on a subquery with a group by does not work
> ------------------------------------------------
>
>                 Key: HIVE-168
>                 URL: https://issues.apache.org/jira/browse/HIVE-168
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: Namit Jain
>         Attachments: 168.patch, patch2, patch3
>
>
>  SELECT a.key, a.value, b.key, b.value
>  FROM 
>   (
>   SELECT src1.key as key, count(src1.value) AS value FROM src src1 group by src1.key
>   ) a
>  FULL OUTER JOIN 
>  (
>   SELECT src2.key as key, count(distinct(src2.value)) AS value 
>   FROM src1 src2 group by src2.key
>  ) b 
>  ON (a.key = b.key);
> does not generate the plan correctly

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-168) join on a subquery with a group by does not work

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Namit Jain updated HIVE-168:
----------------------------

    Attachment: patch2

> join on a subquery with a group by does not work
> ------------------------------------------------
>
>                 Key: HIVE-168
>                 URL: https://issues.apache.org/jira/browse/HIVE-168
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Namit Jain
>            Assignee: Namit Jain
>         Attachments: 168.patch, patch2
>
>
>  SELECT a.key, a.value, b.key, b.value
>  FROM 
>   (
>   SELECT src1.key as key, count(src1.value) AS value FROM src src1 group by src1.key
>   ) a
>  FULL OUTER JOIN 
>  (
>   SELECT src2.key as key, count(distinct(src2.value)) AS value 
>   FROM src1 src2 group by src2.key
>  ) b 
>  ON (a.key = b.key);
> does not generate the plan correctly

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.