[GitHub] [superset] justinpark commented on a diff in pull request #20877: perf(sqllab): Rendering perf improvement using immutable state

[GitBox <gi...@apache.org>]

justinpark commented on code in PR #20877:
URL: https://github.com/apache/superset/pull/20877#discussion_r938056113


##########
superset-frontend/src/SqlLab/actions/sqlLab.test.js:
##########
@@ -24,22 +24,21 @@ import thunk from 'redux-thunk';
 import shortid from 'shortid';
 import * as featureFlags from 'src/featureFlags';
 import * as actions from 'src/SqlLab/actions/sqlLab';
-import { defaultQueryEditor, query } from '../fixtures';
+import { defaultQueryEditor, query, initialState } from 'src/SqlLab/fixtures';
 
 const middlewares = [thunk];
 const mockStore = configureMockStore(middlewares);
 
 describe('async actions', () => {
   const mockBigNumber = '9223372036854775807';
   const queryEditor = {
+    ...defaultQueryEditor,
     id: 'abcd',
     autorun: false,
-    dbId: null,
     latestQueryId: null,
-    selectedText: null,
     sql: 'SELECT *\nFROM\nWHERE',
     name: 'Untitled Query 1',
-    schemaOptions: [{ value: 'main', label: 'main', name: 'main' }],
+    schemaOptions: [{ value: 'main', label: 'main', title: 'main' }],

Review Comment:
   @hughhhh This change(title -> name) accidentally happened [here](https://github.com/apache/superset/pull/20852/files#diff-c489b64153b9a09dc1f0984560850db74bf49af1184bfe68b9f258a44b89105aR42) while the PR made the change for queryEditor title to name.
   
   cc: @lyndsiWilliams 
   
   I reverted this change to pass the type role since I'm following [this type definition](https://github.com/apache/superset/blob/master/superset-frontend/src/SqlLab/components/SaveQuery/index.tsx#L50)
   
   and it's also allocated as `title` here:
   
   https://github.com/apache/superset/blob/eb5369f2a6f2dc238838119eb70194bf2b42b085/superset-frontend/src/components/DatabaseSelector/index.tsx#L224-L228
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org